Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in README.md are 404 when viewed on Gitbook #97

Open
mxmlnglt opened this issue Oct 30, 2019 · 5 comments
Open

Links in README.md are 404 when viewed on Gitbook #97

mxmlnglt opened this issue Oct 30, 2019 · 5 comments

Comments

@mxmlnglt
Copy link

From https://github.com/interagent/http-api-design
"See Summary for Table of Contents." links to:
https://github.com/interagent/http-api-design/blob/master/en/SUMMARY.md
it's OK;

but from Gitbook https://geemus.gitbooks.io/http-api-design/content/en/
this Summary link rewrites to https://geemus.gitbooks.io/http-api-design/content/en/SUMMARY.md
and it's a 404.

Same for the "We welcome contributions to this guide." link:
https://geemus.gitbooks.io/http-api-design/content/CONTRIBUTING.md (404)

@geemus
Copy link
Member

geemus commented Oct 31, 2019

Thanks for letting me know. Any thoughts on how we might go about fixing this? I worry that if I fix it for gitbook it would just break for github...

@tkurki
Copy link

tkurki commented Nov 10, 2021

The links of type https://www.gitbook.com/book/geemus/http-api-design/details no longer work, but for example https://geemus.gitbooks.io/http-api-design/content/en/index.html works.

I'd just remove the ones that no longer work.

geemus added a commit that referenced this issue Nov 16, 2021
@geemus
Copy link
Member

geemus commented Nov 16, 2021

I fixed the link in readme, thanks @tkurki. I think maybe the original issue is a distinct one, but I could be wrong (so I didn't close this yet).

@mxmlnglt
Copy link
Author

I fixed the link in readme, thanks @tkurki. I think maybe the original issue is a distinct one, but I could be wrong (so I didn't close this yet).

I can confirm the original issue is still up...

geemus added a commit that referenced this issue Nov 18, 2021
geemus added a commit that referenced this issue Nov 18, 2021
@geemus
Copy link
Member

geemus commented Nov 18, 2021

Ok, I fixed the contributing/summary links by linking directly to github (I couldn't figure out a way to make it work for both github and gitbook, and summary is duplicative to the sidebar table of contents, so it didn't seem too bad). Gitbook does some remapping of links that it's not totally clear to me what is the right thing to do for relative links, so at least this makes it not 404 for now. If anyone knows how to do this without redirecting back out to github I'm all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants