Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HyperSchema) Refactoring Response Validation to Enhance Consistency #422

Open
chibicco opened this issue May 14, 2024 · 5 comments
Open

Comments

@chibicco
Copy link
Contributor

Overview

I am considering moving the status_code=204 && empty response check to the SchemaValidator::HyperSchema::ResponseValidator to maintain consistency with the following PR.

ref: https://github.com/interagent/committee/pull/417/files#r1597413928

I plan to create a PR myself, but I would appreciate it if you could let me know if there are any other potential solutions.

@ydah
Copy link
Member

ydah commented May 20, 2024

There are no other ideas at this time, so you can work on this when you want to.

@chibicco
Copy link
Contributor Author

I'm sorry, but I've been busy with my main job and haven't been able to respond m(_ _)m
I plan to create the PR within June.

I apologize for any inconvenience and appreciate your understanding.

@ydah
Copy link
Member

ydah commented May 27, 2024

@chibicco You don't have to apologize😀 Because this is an OSS project, not a job.
Please work on it when you want to. Don't worry about the pace of work 👍🏻

@chibicco
Copy link
Contributor Author

Hi,
As we project has transitioned to OpenAPI 3.0, I no longer have opportunities to utilize the 2.0 logic.
I will be deferring any revisions regarding this matter 🙇

@geemus
Copy link
Member

geemus commented Oct 18, 2024

@chibicco thanks for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants