Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Split SDK and CLI #168

Open
michal-cech opened this issue Jul 13, 2022 · 5 comments
Open

[Suggestion] Split SDK and CLI #168

michal-cech opened this issue Jul 13, 2022 · 5 comments

Comments

@michal-cech
Copy link

Hello, would it be possible to split Python SDK and CLI app projects so that there is a lower probability that SDK clashes with some other projects because of CLI only library? If not, would it be possible to not put such strict requirements on the rich library?

@mlodic
Copy link
Member

mlodic commented Jul 13, 2022

hey, specifically from which version of rich you are clashing?

Anyway yeah this makes sense, we could split those requirements and provide different installation options like pyintelowl[cli] and pyintelowl[sdk]

If you want to help us please feel free to submit a PR

@michal-cech
Copy link
Author

To be specific, I want to use pyintelowl in a custom operator in Apache Airflow. I encountered this issue while wanting to upgrade Airflow from 2.2.4 to +2.3, since it requires the newest versions of rich (2.3.3 Airflow requires rich>=12.4.4).

@mlodic
Copy link
Member

mlodic commented Jul 14, 2022

Thanks for sharing your use case. Could I take this opportunity to ask you more about how you use IntelOwl? It would be very useful for us to understand how to bring forward the project. You can also reach me in private on Twitter in case.

Then, about your problem, the fastest thing that I can do it to make another release where I soften the requirement of rich. I'm about to do that (see #170). 4.2.0 will be

@mlodic
Copy link
Member

mlodic commented Jul 14, 2022

done, please use 4.2.0 version and you'll be ok

@mlodic mlodic closed this as completed Jul 14, 2022
@mlodic mlodic reopened this Jul 14, 2022
@mlodic
Copy link
Member

mlodic commented Jul 14, 2022

keeping it open for the job of splitting the SDK with the the CLI

@mlodic mlodic closed this as completed Jul 14, 2022
@mlodic mlodic reopened this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants