Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for proxy #160

Open
mlodic opened this issue Jun 7, 2022 · 6 comments
Open

Option for proxy #160

mlodic opened this issue Jun 7, 2022 · 6 comments

Comments

@mlodic
Copy link
Member

mlodic commented Jun 7, 2022

referred to #145

@Ektoplasma
Copy link

Hello! Any update on that?

@mlodic
Copy link
Member Author

mlodic commented Nov 3, 2022

nope! you are free to contribute to it and add it. It's not a complicated feature

@Ektoplasma
Copy link

I simply added the proxy setting to IntelOwl's requests session.

I also tried to modify the main.py file in order to add the possibility to use proxy settings from the cli, but I couldn't make it work.

@mlodic
Copy link
Member Author

mlodic commented Nov 5, 2022

I sightlty adjusted your PR and pushed a 4.4.0 with this. The option from the CLI is still not available because I remained stuck in the usage of that click-creds library and couldn't make it work fast.

@mlodic
Copy link
Member Author

mlodic commented Nov 5, 2022

sorry if I closed your PR but that would have been faster like this than asking you to fix things there were there. Next time please follow all the recommendations that you can find in the PR template

@Ektoplasma
Copy link

Got it. I indeed squeezed all the Checklist part ahah. Thanks for the 4.4.0 update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants