From 9a97fcc821198d7219fecc57926ae542067eef53 Mon Sep 17 00:00:00 2001 From: Matteo Lodi <30625432+mlodic@users.noreply.github.com> Date: Thu, 8 Feb 2024 16:40:34 +0100 Subject: [PATCH] little fix for playbook requests without a tlp set --- .github/CHANGELOG.md | 3 +++ docs/conf.py | 2 +- pyintelowl/pyintelowl.py | 10 ++++++++-- pyintelowl/version.py | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/CHANGELOG.md b/.github/CHANGELOG.md index 0f20977..f3e37c9 100644 --- a/.github/CHANGELOG.md +++ b/.github/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## [4.4.7](https://github.com/intelowlproject/pyintelowl/releases/tag/4.4.7) +- Fixed Running Playbook without TLP set + ## [4.4.6](https://github.com/intelowlproject/pyintelowl/releases/tag/4.4.6) - Readded default TLP for analysis as TLP:CLEAR for "classic" analyses only (the ones that do not leverage a Playbook) diff --git a/docs/conf.py b/docs/conf.py index df939a9..d17c82e 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -13,7 +13,7 @@ import os import sys -VERSION = "4.4.6" +VERSION = "4.4.7" GITHUB_URL = "https://github.com/intelowlproject/pyintelowl" sys.path.append(os.path.abspath("../")) diff --git a/pyintelowl/pyintelowl.py b/pyintelowl/pyintelowl.py index 1302e24..dde37d6 100644 --- a/pyintelowl/pyintelowl.py +++ b/pyintelowl/pyintelowl.py @@ -253,9 +253,12 @@ def send_file_analysis_playbook_request( runtime_configuration = {} data = { "playbooks_requested": playbooks_requested, - "tlp": tlp, "tags_labels": tags_labels, } + # send this value only if populated, + # otherwise the backend would give you 400 + if tlp: + data["tlp"] = tlp if runtime_configuration: data["runtime_configuration"] = json.dumps(runtime_configuration) @@ -413,10 +416,13 @@ def send_observable_analysis_playbook_request( data = { "observables": [[observable_classification, observable_name]], "playbooks_requested": playbooks_requested, - "tlp": tlp, "tags_labels": tags_labels, "runtime_configuration": runtime_configuration, } + # send this value only if populated, + # otherwise the backend would give you 400 + if tlp: + data["tlp"] = tlp answer = self.__send_analysis_request( data=data, files=None, playbook_mode=True ) diff --git a/pyintelowl/version.py b/pyintelowl/version.py index 3a55d6b..d2eb259 100644 --- a/pyintelowl/version.py +++ b/pyintelowl/version.py @@ -1 +1 @@ -__version__ = "4.4.6" +__version__ = "4.4.7"