Job exit when all nodecheck failed #1323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2024 20:54
and if yes, stop the job. it happens in workers of AllReduce_Strategy jobs
majieyue
requested review from
workingloong,
samplise and
BalaBalaYi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
+ Coverage 80.46% 80.48% +0.02%
==========================================
Files 222 222
Lines 20740 20760 +20
==========================================
+ Hits 16688 16709 +21
+ Misses 4052 4051 -1 ☔ View full report in Codecov by Sentry. |
samplise
reviewed
Nov 7, 2024
| 0, | ||
| msg, | ||
| level=TrainingExceptionLevel.RDZV_ERROR, | ||
| ) |
There was a problem hiding this comment.
process_error(message=msg, level=...)
BalaBalaYi
requested changes
Nov 7, 2024
| @@ -118,6 +118,7 @@ class JobExitReason(object): | |||
| RDZV_TIMEOUT_ERROR = "RdzvTimeout" | |||
| PENDING_TIMEOUT = "PendingTimeout" | |||
| UNCOMPLETED_TIMEOUT = "UncompletedTimeout" | |||
| RDZV_ALL_FAILED = "RdzvAllFailed" | |||
There was a problem hiding this comment.
Change name to 'NodeCheckFailed'. This is actually a training failure, not a rdzv failure.
| @@ -243,7 +243,42 @@ def is_all_reduce_type_job(self): | |||
| == DistributionStrategy.ALLREDUCE | |||
| ) | |||
|
|
|||
| def is_all_workers_node_check_failed(self): | |||
There was a problem hiding this comment.
Better move this function into WorkerManager. And work for 'AllReduceType' training only.
workingloong
reviewed
Nov 7, 2024
| return all( | ||
| [ | ||
| node.is_node_check_failed() | ||
| for _, node in self._job_nodes[NodeType.WORKER].items() |
There was a problem hiding this comment.
for node in self._job_nodes[NodeType.WORKER].values()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
exit job if all workers can't pass node check
Why are the changes needed?
no need to re-check or try to fault tolerant this error
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT