Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygamma: UT failure #622

Closed
4 tasks done
fengyuan14 opened this issue Jul 21, 2024 · 3 comments
Closed
4 tasks done

Polygamma: UT failure #622

fengyuan14 opened this issue Jul 21, 2024 · 3 comments
Assignees
Milestone

Comments

@fengyuan14
Copy link
Contributor

fengyuan14 commented Jul 21, 2024

Triage is done

🐛 Describe the bug

Please evaluate inf in the error log, whether it is caused by numerical error when calculating a extremal large number. 4 failures,

=========================== short test summary info ============================
FAILED test_unary_ufuncs_xpu.py::TestUnaryUfuncsXPU::test_reference_numerics_normal_polygamma_polygamma_n_1_xpu_float16 - AssertionError: Tensor-likes are not close!

Mismatched elements: 8 / 943593 (0.0%)
Greatest absolute difference: inf at index (9, 860) (up to 0.001 allowed)
Greatest relative difference: inf at index (9, 860) (up to 0.0012 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_SLOW=1 python test/test_unary_ufuncs.py -k TestUnaryUfuncsXPU.test_reference_numerics_normal_polygamma_polygamma_n_1_xpu_float16

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED test_unary_ufuncs_xpu.py::TestUnaryUfuncsXPU::test_reference_numerics_normal_polygamma_polygamma_n_2_xpu_float16 - AssertionError: Tensor-likes are not close!

Mismatched elements: 8 / 943593 (0.0%)
Greatest absolute difference: inf at index (9, 860) (up to 0.001 allowed)
Greatest relative difference: inf at index (9, 860) (up to 0.0012 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_SLOW=1 python test/test_unary_ufuncs.py -k TestUnaryUfuncsXPU.test_reference_numerics_normal_polygamma_polygamma_n_2_xpu_float16

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED test_unary_ufuncs_xpu.py::TestUnaryUfuncsXPU::test_reference_numerics_normal_polygamma_polygamma_n_3_xpu_float16 - AssertionError: Tensor-likes are not close!

Mismatched elements: 8 / 943593 (0.0%)
Greatest absolute difference: inf at index (9, 860) (up to 0.001 allowed)
Greatest relative difference: inf at index (9, 860) (up to 0.0012 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_SLOW=1 python test/test_unary_ufuncs.py -k TestUnaryUfuncsXPU.test_reference_numerics_normal_polygamma_polygamma_n_3_xpu_float16

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED test_unary_ufuncs_xpu.py::TestUnaryUfuncsXPU::test_reference_numerics_normal_polygamma_polygamma_n_4_xpu_float16 - AssertionError: Tensor-likes are not close!

Mismatched elements: 8 / 943593 (0.0%)
Greatest absolute difference: inf at index (9, 860) (up to 0.001 allowed)
Greatest relative difference: inf at index (9, 860) (up to 0.0012 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_SLOW=1 python test/test_unary_ufuncs.py -k TestUnaryUfuncsXPU.test_reference_numerics_normal_polygamma_polygamma_n_4_xpu_float16

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
= 4 failed, 15584 passed, 552 skipped, 2299 deselected, 16 xfailed in 131.29s (0:02:11) =

Versions

#555

@fengyuan14 fengyuan14 added this to the PT2.5 milestone Jul 21, 2024
This was referenced Jul 30, 2024
@daisyden
Copy link
Contributor

daisyden commented Aug 1, 2024

XPU got the similar issue as cpu backend, both cpu and xpu float16 range has gap with scipy. CPU issue is submitted pytorch/pytorch#132386 with example code.

@daisyden
Copy link
Contributor

@yuchengliu1 please adjust tolerance for this case.

@daisyden
Copy link
Contributor

tracked in #754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants