Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case regression due to PyTorch uplift #614

Closed
3 tasks done
daisyden opened this issue Jul 18, 2024 · 5 comments
Closed
3 tasks done

Case regression due to PyTorch uplift #614

daisyden opened this issue Jul 18, 2024 · 5 comments
Assignees
@daisyden @yuchengliu1
Labels
ut_triaged
Milestone
PT2.5

Comments

@daisyden
Copy link
Contributor

daisyden commented Jul 18, 2024 •
edited
Loading

🐛 Describe the bug

Closed #549, keep the rest of the issue here.

New failures occur when PyTorch uplifts.
Guilty commit should be between f053be2a97e1f6f9b2252cb800edd46f720af502 and d44c30e2f90d9ebe829875324f0ac662d04833a8.

  • test_compare_cpu_nn_functional_batch_norm_xpu_float16
  • test_compare_cpu_std_mean_xpu_bfloat16
  • test_compare_cpu_var_mean_xpu_bfloat16

all within the threashold.

Versions

Latest PyTorch.
@daisyden daisyden self-assigned this Jul 18, 2024
@daisyden daisyden mentioned this issue Jul 18, 2024
Closed
6 tasks
@daisyden
Copy link
Contributor Author

The two cases can pass with updated threshold.

image

image

@chuanqi129 chuanqi129 added this to the PT2.5 milestone Jul 23, 2024
@xytintel
Copy link
Contributor

The error of test_compare_cpu_nn_functional_batch_norm_xpu_float16 is small.
image

This was referenced Jul 30, 2024
Closed
Closed
@yuchengliu1 yuchengliu1 self-assigned this Aug 6, 2024
@daisyden
Copy link
Contributor Author

@yuchengliu1 please configure tolerance for these cases.

@yuchengliu1
Copy link
Contributor

test_compare_cpu_nn_functional_batch_norm_xpu_float16 pass in #749

@yuchengliu1
Copy link
Contributor

"test_compare_cpu_nn_functional_batch_norm_xpu_float16",
"test_compare_cpu_std_mean_xpu_bfloat16",
"test_compare_cpu_var_mean_xpu_bfloat16",
pass in #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daisyden daisyden

@yuchengliu1 yuchengliu1

Labels
ut_triaged
Projects
None yet
Milestone
PT2.5
Development

No branches or pull requests
4 participants
@chuanqi129 @daisyden @xytintel @yuchengliu1