Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace errors due to forgotten addInput can be detected only upon instantiation in a Module not a test #136

Open
desmonddak opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@desmonddak
Copy link
Contributor

Describe the bug

Creating a component, instantiating in a directed test, and testing will NOT uncover a forgotten addInput.

Yet, instantiating that component in another module does uncover trace errors.

For the HCL, it would be good if we can eliminate this source of errors that show up late.

To Reproduce

Create a simple component, but don't use addInput for one of the inputs (or delete the addInput for an existing component -- in one case it was an optional input that was driven).

then instantiate that component in a simple wrapper module and drive with a similar test. You will see a connectivity trace error.

Expected behavior

We expect trace errors show up during basic directed tests which are required of most component.s

Actual behavior

We see trace errors show up only when the component is used and this is typically a forgotten addInput.

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

A possible solution is to create a wrap routine that instantiates a module by mirroring its ports. This would be enough to catch trace errors due to forgotten addInput routines.

@desmonddak desmonddak added the bug Something isn't working label Nov 13, 2024
@desmonddak desmonddak changed the title Trace errors due to forgotten addInput can be detected only upon instantiation Trace errors due to forgotten addInput can be detected only upon instantiation in a Module not a test Nov 13, 2024
@mkorbel1
Copy link
Contributor

The configurator tests instantiate modules already, perhaps we can leverage that to also test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants