Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

use recommended labels for PMEM-CSI deployments #850

Closed
pohly opened this issue Jan 13, 2021 · 3 comments
Closed

use recommended labels for PMEM-CSI deployments #850

pohly opened this issue Jan 13, 2021 · 3 comments
Labels

Comments

@pohly
Copy link
Contributor

pohly commented Jan 13, 2021

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

This replaces our current usage of "app" as label, which is ambiguous: does it name the component independently of the CSI driver name or does it encode the driver name? We can avoid that with:

        app.kubernetes.io/name: pmem-csi-controller # fixed
        app.kubernetes.io/part-of: pmem-csi # fixed
        app.kubernetes.io/component: controller # fixed
        app.kubernetes.io/instance: pmem-csi.intel.com #CSI driver name, varies

This is slightly redundant, but that's intentional because it provides more flexibility for filtering.

@pohly
Copy link
Contributor Author

pohly commented Jan 13, 2021

I am making that change for the PMEM-CSI driver because I need it for supporting the scheduler extensions with more than one driver.

I am leaving deploy/kustomize/operator/operator.yaml unchanged for now.

@pohly
Copy link
Contributor Author

pohly commented Jan 13, 2021

I am leaving out app.kubernetes.io/version for now. Whether we want to add that can be treated as a separate issue.

@pohly pohly added the 0.9 label Jan 18, 2021
@pohly pohly changed the title use recommended labels use recommended labels for PMEM-CSI deployments Jan 18, 2021
@pohly
Copy link
Contributor Author

pohly commented Jan 20, 2021

Solved as part of PR #838

@pohly pohly closed this as completed Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant