Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USM/fill_any_size.cpp XPASS in OCL CPU in Nightly #16434

Closed
sarnex opened this issue Dec 19, 2024 · 6 comments · Fixed by #16544
Closed

USM/fill_any_size.cpp XPASS in OCL CPU in Nightly #16434

sarnex opened this issue Dec 19, 2024 · 6 comments · Fixed by #16544
Labels
bug Something isn't working

Comments

@sarnex
Copy link
Contributor

sarnex commented Dec 19, 2024

Describe the bug

I tried just removing the XFAIL but then it fails in precommit on OCL CPU, which is really weird

#16433

Needs investigation

 XPASS: SYCL :: USM/fill_any_size.cpp (1994 of 2242)
******************** TEST 'SYCL :: USM/fill_any_size.cpp' FAILED ********************
Exit Code: 0

Command Output (stdout):
--
# RUN: at line 1
/__w/llvm/llvm/toolchain/bin//clang++ -D_GLIBCXX_USE_CXX11_ABI=0  -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/USM/fill_any_size.cpp -o /__w/llvm/llvm/build-e2e/USM/Output/fill_any_size.cpp.tmp1.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -D_GLIBCXX_USE_CXX11_ABI=0 -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/USM/fill_any_size.cpp -o /__w/llvm/llvm/build-e2e/USM/Output/fill_any_size.cpp.tmp1.out
# note: command had no output on stdout or stderr
# RUN: at line 2
env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/USM/Output/fill_any_size.cpp.tmp1.out
# executed command: env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/USM/Output/fill_any_size.cpp.tmp1.out
# .---command stdout------------
# | All 64 tests passed
# `-----------------------------

--

https://github.com/intel/llvm/actions/runs/12405518106/job/34632838094

To reproduce

No response

Environment

No response

Additional context

No response

@sarnex sarnex added the bug Something isn't working label Dec 19, 2024
@sarnex
Copy link
Contributor Author

sarnex commented Dec 19, 2024

FYI @rafbiels

@rafbiels
Copy link
Contributor

Thanks for flagging. This is expected, the issue happens semi-randomly as explained in the linked oneapi-src/unified-runtime#2440. This is a memory alignment issue so any change in memory layout from an unrelated change (even as simple as renaming the binary) may cause the issue to disappear or reappear.

Shall I change the XFAIL to UNSUPPORTED to avoid XPASS reports? In principle this is "supported", just the implementation has a bug.

@sarnex
Copy link
Contributor Author

sarnex commented Dec 20, 2024

thanks for the explanation, yeah if its sporadic lets make it UNSUPPORTED, thats what we usually do for sporadic failures, thx

@rafbiels
Copy link
Contributor

rafbiels commented Jan 7, 2025

The fix PR #16443 got held up over my holiday and the test addition was reverted instead in #16465. I'll resubmit the test addition with UNSUPPORTED shortly.

@rafbiels
Copy link
Contributor

rafbiels commented Jan 7, 2025

@sarnex would you be able to advise on how to format the UNSUPPORTED-TRACKER line given that the clang-format check fails with the following suggestion:

-// UNSUPPORTED-TRACKER: https://github.com/oneapi-src/unified-runtime/issues/2440
+// UNSUPPORTED-TRACKER:
+// https://github.com/oneapi-src/unified-runtime/issues/2440

I assume there are parsers extracting this information from the comment. Do they allow a line break here? Is this documented somewhere?

@sarnex
Copy link
Contributor Author

sarnex commented Jan 7, 2025

the grep string is here, but i would just do

// clang-format off
// UNSUPPORTED: whatever
// clang-format on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants