Skip to content

Commit 06290b2

Browse files
authored
[SYCL][Coverity] Fix invalid iterator coverity hit (#17944)
In `ProgramManager::removeImages`, we cleanup our KernelName2KernelID mapping, before using that exact mapping retrieve KernelIDs in order to clean up our KernelIDs2BinImage mapping. This PR cleans up `m_KernelID2BinImage` mapping before cleaning up `m_KernelName2KernelIDs` maping. This is inteded to fix a hit raised by Coverity.
1 parent ac30857 commit 06290b2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sycl/source/detail/program_manager/program_manager.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2186,8 +2186,8 @@ void ProgramManager::removeImages(sycl_device_binaries DeviceBinary) {
21862186

21872187
if (auto It = m_KernelName2KernelIDs.find(EntriesIt->GetName());
21882188
It != m_KernelName2KernelIDs.end()) {
2189-
m_KernelName2KernelIDs.erase(It);
21902189
m_KernelIDs2BinImage.erase(It->second);
2190+
m_KernelName2KernelIDs.erase(It);
21912191
}
21922192
}
21932193

0 commit comments

Comments
 (0)