Commit 93d36726 breaks the camera on Lenovo ThinkPad X1 carbon gen 12 models

[jwrdegoede]

Commit 93d3672 breaks the camera on Lenovo ThinkPad X1 carbon gen 12 models.

These laptops have a 'CJFME55' sensor module id, so I think this may be related to this part of the change:

-        <supportedTuningConfig value="NORMAL,VIDEO,OV08X40_CJFME55_MTL,
-                                      STILL_CAPTURE,VIDEO,OV08X40_CJFME55_MTL"/>
+        <supportedTuningConfig value="NORMAL,VIDEO,OV08X40_BBG802N3_RG_MTL,
+                                     STILL_CAPTURE,VIDEO,OV08X40_BBG802N3_RG_MTL"/>

After this change I get the following output launching a gst pipeline with icamerasrc:

hans@x1:~$ gst-launch-1.0 icamerasrc buffer-count=7 ! video/x-raw,format=NV12,width=1280,height=720 ! videoconvert ! xvimagesink  
Setting pipeline to PAUSED ...
[02-01 14:52:56.811] CamHAL[INF] aiqb file name OV08X40_BBG802N3_RG_MTL.aiqb
[02-01 14:52:56.811] CamHAL[INF] aiqb file name OV08X40_BBG802N3_RG_MTL.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
[02-01 14:52:56.813] CamHAL[INF] aiqb file name AR0234_TGL_10bits.aiqb
Pipeline is live and does not need PREROLL ...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
[02-01 14:52:56.965] CamHAL[ERR] Start: Device node /dev/video1 IOCTL VIDIOC_STREAMON error: Broken pipe
[02-01 14:52:56.965] CamHAL[ERR] Device:Generic stream on failed.
[02-01 14:52:56.965] CamHAL[ERR] Devices stream on failed:-38
[02-01 14:52:56.965] CamHAL[ERR] Start capture unit failed with ret:-38.
[02-01 14:52:56.965] CamHAL[ERR] Camera device starts failed.
[02-01 14:52:56.965] CamHAL[WAR] @stop: device not started

[jwrdegoede]

Cc @drhooray this breakage is caused by a recent change from you, can you take a look please?

[drhooray]

Thanks for the heads up, Hans.

Because the patch also requires driver patches.
The driver patches are currently under internal review. Once they are approved to upstream. I will update the status.

You can assign the issue to me for tracking.