Skip to content

Commit f6ad2ae

Browse files
committed
just skip the bad objects
1 parent 50dac90 commit f6ad2ae

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

cachelib/allocator/CacheAllocator.h

+7-8
Original file line numberDiff line numberDiff line change
@@ -1789,10 +1789,12 @@ class CacheAllocator : public CacheBase {
17891789
if(toReleaseHandle) {
17901790
movedToNextTier = true;
17911791
} else {
1792-
toReleaseHandle =
1793-
itr->isChainedItem()
1794-
? advanceIteratorAndTryEvictChainedItem(tid, pid, itr)
1795-
: advanceIteratorAndTryEvictRegularItem(tid, pid, mmContainer, itr);
1792+
//toReleaseHandle =
1793+
// itr->isChainedItem()
1794+
// ? advanceIteratorAndTryEvictChainedItem(tid, pid, itr)
1795+
// : advanceIteratorAndTryEvictRegularItem(tid, pid, mmContainer, itr);
1796+
//just bump the iterator and move on with life
1797+
++itr;
17961798
}
17971799

17981800
if (toReleaseHandle) {
@@ -1823,10 +1825,7 @@ class CacheAllocator : public CacheBase {
18231825
releaseBackToAllocator(itemToRelease, RemoveContext::kEviction,
18241826
/* isNascent */ movedToNextTier, candidate);
18251827

1826-
} else {
1827-
//evict failed - let's quit with what we have
1828-
break;
1829-
}
1828+
}
18301829

18311830
}
18321831

0 commit comments

Comments
 (0)