Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

vdiv - wrong output, misunderstanding of device function #25

Open
jontrulson opened this issue Jul 26, 2016 · 1 comment
Open

vdiv - wrong output, misunderstanding of device function #25

jontrulson opened this issue Jul 26, 2016 · 1 comment

Comments

@jontrulson
Copy link
Collaborator

  • This driver is just wrong. It appears that someone didn't read the
    datasheet to understand what this device actually does. :)

  • The 'scale' needs to be specified to init(). This has nothing to do
    with FTI scaling - rather there is an actual switch on the device
    that must be accounted for when computing voltage.

  • And the output value should be an actual voltage, not a normalized ADC
    value (computedValue() in original CXX file). The whole purpose of
    the device is for measuring voltage :)

    Like others, this device does not average samples like it should.
    Needs fixing.

@pylbert
Copy link
Contributor

pylbert commented Jul 27, 2016

Noted - will update to use the gain in the c src.

jontrulson added a commit that referenced this issue Oct 24, 2016
Currently, there are just not enough available GPIOS to properly
driver this from the x86 core.  There is a PR (#25) in ZMRAA that
should fix this problem, but it has not been merged yet.

My understanding is that GPIO is not available from the ARC core at
all yet either, so...  That too may be addressed in PR #25.

Signed-off-by: Jon Trulson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants