Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's use .iml.jsonc extension instead of .iml.json #193

Open
shumov opened this issue Aug 17, 2024 · 3 comments
Open

Let's use .iml.jsonc extension instead of .iml.json #193

shumov opened this issue Aug 17, 2024 · 3 comments

Comments

@shumov
Copy link

shumov commented Aug 17, 2024

Amazing product. Love it!

Why do files created in JSONC format use the .json extension?
The file ends up in an invalid format, causing errors:

GitLab shows an error image
All other editors show an error as well image

When I manually change the file extension, everything works fine, but the syntax highlighting in VSCode stops working.

@shumov
Copy link
Author

shumov commented Aug 17, 2024

I created this PR use iml.jsonc instead of iml.json #194

@ma-zal
Copy link
Collaborator

ma-zal commented Sep 24, 2024

Hi @shumov. Did you try to rename file(s) to .jsonc to check if you see highlights correctly in GitLab and in your IDE (it looks like JetBrains)? I am a bit afraid of some editors/viewers, which decide the .jsonc as plaintext only.

@ma-zal
Copy link
Collaborator

ma-zal commented Sep 27, 2024

After considering it, I offer the backward compatible solution. We can keep the json as default, but we will add a new configuration option:

In settings.json:

// Overrides the default extension of created JSONC files (default is `json`).
// Value can be `jsonc`.
"apps-sdk.localDev.defaultJsoncFileExtension": "jsonc",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants