Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: group_description in github_team_sync_group_mapping constantly recreated on change #2423

Open
1 task done
akorp opened this issue Oct 13, 2024 · 0 comments
Open
1 task done
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@akorp
Copy link

akorp commented Oct 13, 2024

Expected Behavior

When a group_description is changed in IdPs (for example Azure Entra), the change in github_team_sync_group_mapping should persist on applying Terraform.

Actual Behavior

When a group_description is changed in IdPs (for example Azure Entra), terraform see the change and try to update the group block in github_team_sync_group_mapping. However the change with the new group_description does not persist. During next runs, terraform still shows the difference and constantly will try to update.

This could be related on how GitHub API handles updates to Identity Provider Groups. Some observation on similarity in GitHub GUI that might be relevant:

  • Change description of Azure Entra group which is connected to GitHub team.
  • Go to GitHub team setting Identity Provider Groups. Entra group will have the old description. If we try to remove the Entra group and add it again, the Entra group description will be updated, but the changes to the group description are not saved on pressing save. The group should be removed, saved and then added again to reflect the change to the description.

Terraform Version

Terraform 1.9.7
integrations/github v5.45.0

Affected Resource(s)

  • github_team_sync_group_mapping

Terraform Configuration Files

No response

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@akorp akorp added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Oct 13, 2024
@akorp akorp changed the title [BUG]: group_description in github_team_sync_group_mapping constantly recreated on change [BUG]: group_description in github_team_sync_group_mapping constantly recreated on change Oct 13, 2024
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Oct 15, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

2 participants