Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Support Push Rulesets #2394

Open
1 task done
srgustafson8 opened this issue Sep 20, 2024 · 5 comments
Open
1 task done

[FEAT]: Support Push Rulesets #2394

srgustafson8 opened this issue Sep 20, 2024 · 5 comments
Labels
Type: Feature New feature or request

Comments

@srgustafson8
Copy link
Contributor

srgustafson8 commented Sep 20, 2024

Describe the need

GitHub launched push rules for rulesets to GA recently where you can allow only a certain team or group to push particular paths or files. The API appears to support push rule targets for both Repository and Organisation.

It would be great to be able to support creating and managing these with terraform. This is depends on google/go-github#3274 adding support in the SDK.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@srgustafson8 srgustafson8 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Sep 20, 2024
@akmalharith
Copy link

Was this ever released #2351?

@srgustafson8
Copy link
Contributor Author

@akmalharith I was wrong in my original assessment, support for push existed in the SDK but not for 3/4 of the rule types for push rules. I have opened a PR to add them to the SDK then will pick this up once merged and upgraded.

@kfcampbell
Copy link
Member

@akmalharith FWIW #2351 was released as part of v6.3.0.

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Sep 27, 2024
@TheArtheist
Copy link

google/go-github#3274 is part of the version v66.0.0 which is now released. I have created #2419.

@kieran-lowe
Copy link

Would be awesome to get this merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants