Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface containing blob permalinks does not enclose with code blocks #1989

Open
adlai opened this issue Dec 12, 2024 · 0 comments
Open

Surface containing blob permalinks does not enclose with code blocks #1989

adlai opened this issue Dec 12, 2024 · 0 comments
Assignees
Labels

Comments

@adlai
Copy link

adlai commented Dec 12, 2024

Describe the bug
The message triggered by creation of an Issue that includes permalinks into code within the same repository does not render using a monospace code block in the displayed surface.

To Reproduce
Hoping that you're dogfooding, I will include one of these failures in the Slack message that should be triggered by the creation of this Issue... if so, scroll to the end of this message's surface.

If not, here are the steps to reproduce the behavior:

  1. If you're not dogfooding, create a new issue in a repository that has slack notifications from the github integration enabled;
  2. From the code browser of that repository, select some lines of code using the line numbers, and copy the permalink using the dropdown menu from the ellipsis that appears by the selection;
  3. Submit the issue;
  4. Open the Unreads view from app.slack.com and locate the offending message from the GitHub App.

Expected behavior
The lines of code quoted in the permalink should be enclosed in a multi-line code block.

Screenshots
My workstation does not currently allow screenshots.

Desktop (please complete the following information):

  • OS: "btw I'm using Arch linux"
  • Browser: Chromium
  • Version: >= 131

Additional context
I first encountered this in a private Slack group, and I'm not currently in your organisation where this issue might demonstrate the bug, so please tell me if you neither see it below nor can reproduce it from my instructions above.

# The name of the repository. Changing this will rename the repository
name: slack
# A short description of the repository that will show up on GitHub
description: Bring your code to the conversations you care about with the GitHub and Slack integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants