You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's handy that StripeEvent does signature verification of stripe messages and responds appropriately (with :bad_request). However, since StripeEvent catches those exceptions and doesn't re-raise, there isn't any way for us to catch and report on Stripe::SignatureVerificationErrors (like, say to bugsnag or newrelic).
I would like these errors re-raised such that the containing application can handle them as necessary, with our own logging and error reporting.
The text was updated successfully, but these errors were encountered:
@jasonkarns I don't think these errors can be re-raised. Otherwise, we wouldn't be able to respond with the same :bad_request response.
However, what we might be able to add is a configuration hook mechanism to tie into the error handler so that you can report the error (within your specific application) to tools like bugsnag, rollbar, etc.
🤔 I'll noodle on this. In the meantime, if others have implementation ideas and/or pull-requests in mind, let's start a discussion.
Could add a configuration option which accepts a Callable (block/proc/object-with-call-method) which accepts the error object. If not provided, the default callable could just be the current log_error method.
https://github.com/integrallis/stripe_event/blob/master/app/controllers/stripe_event/webhook_controller.rb#L10-L13
It's handy that StripeEvent does signature verification of stripe messages and responds appropriately (with
:bad_request
). However, since StripeEvent catches those exceptions and doesn't re-raise, there isn't any way for us to catch and report onStripe::SignatureVerificationError
s (like, say to bugsnag or newrelic).I would like these errors re-raised such that the containing application can handle them as necessary, with our own logging and error reporting.
The text was updated successfully, but these errors were encountered: