-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could netcdf4 be pulled out to isolate GPL code? #41
Comments
To be clear, I would be happy to do the work to make this happen if the maintainers of this package support the change. |
It would be ok by me to have this only as an optional dependency, but, of course, the docs had better be clear (and good error message on import failure). |
Yeah I am consistently surprised by the dependency on netcdf4. xarray doesn't depend on netcdf4, so we can probably look there for good error messaging. |
It's my understanding that the license inccompatibility issue in netcdf4-ptyhon/cftime got fixed a few days ago: Unidata/netcdf4-python#1073. |
Seems like the conscensus here is that it would be fine to remove the xarray dep, but I'm not sure whether there is any motivation for doing that if the license issue is resolved. |
I think
netcdf4
is inflected with GPL code. I'm wondering if it could be made an optional dependency ofintake-xarray
, or moved into a separateintake-netcdf4
package.Although conda-forge reports that netcdf4 has an MIT liencse, netcdf4 has a hard dependency on
cftime
which has a GPL license.h/t @dylanmcreynolds who noticed this problem.
The text was updated successfully, but these errors were encountered: