You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
change the minimum height of the iframe used for LTI messages
why
The iframe used for LTI messages has 450px as minimum height
When the user zooms in the browser (3-400%) the visible viewport
will be much smaller than the min-height (450px) of the iframe
which causes problem and the focused elements are not visible
Instead of setting an absolute value for this property, we can
use 100% of the iframe's height
fixes INTEROP-7093
flag=none
Test plan
Compile the CSS. Run:
rake css:compile
Compile the JS. Run:
rake js:webpack_development
Launch any LTI tool
Open the Browser Developer Tools (F12)
Locate the HTML element iframe#tool_content
Check the height property of the iframe. It should allow values
below 450px when zooming in
Using LTI 1.3.
It is impossible to override the iframe height in a smaller size than 450px. which makes it hard for other plugins to be visible properly.
// Send the resize message to Canvas try { window.parent.postMessage({ subject: 'lti.frameResize', height: '200px', 'min-height': '200px', max_height: '200px', token: token }, '*'); } catch (e) { console.error('Failed to send resize message:', e); }
Smaller then 450px will just not happen. The previous 100% worked properly. Shouldnt the minimum height be applied to the component where it belongs?
078a06d
change the minimum height of the iframe used for LTI messages
why
The iframe used for LTI messages has 450px as minimum height
When the user zooms in the browser (3-400%) the visible viewport
will be much smaller than the min-height (450px) of the iframe
which causes problem and the focused elements are not visible
Instead of setting an absolute value for this property, we can
use 100% of the iframe's height
fixes INTEROP-7093
flag=none
Test plan
Launch any LTI tool
Open the Browser Developer Tools (F12)
Locate the HTML element iframe#tool_content
Check the height property of the iframe. It should allow values
below 450px when zooming in
Change-Id: I4b20909d3accdb00de3320de7b3ecc61997e4df0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282126
Tested-by: Service Cloud Jenkins [email protected]
Product-Review: Karl Lloyd [email protected]
Reviewed-by: Tucker Mcknight [email protected]
QA-Review: Tucker Mcknight [email protected]
The text was updated successfully, but these errors were encountered: