Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergify fails to merge release-v0.7 PRs with all positive reviews #572

Open
ktdreyer opened this issue Mar 14, 2025 · 1 comment
Open

mergify fails to merge release-v0.7 PRs with all positive reviews #572

ktdreyer opened this issue Mar 14, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ktdreyer
Copy link

Describe the bug
Mergify failed to merge a PR that it should have merged. Nathan discovered that Mergify is mis-configured on the release-v0.7 branch.

To Reproduce
Steps to reproduce the behavior:

  1. Create a PR
  2. Have two reviewers approve it
  3. Wait for mergify to merge it
  4. 💀 wait forever

Expected behavior
Mergify merges it as soon as the reviewers have approved it

@ktdreyer
Copy link
Author

We need to determine if functional-gpu-small-workflow-complete should exist on the release-v0.7 branch:

  • If that test should exist on that branch, we should add it to satisfy the rules in .github/mergify.yml.
  • If it should not exist on that branch, we should remove it from .github/mergify.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant