Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider import from react native resolved #51

Open
Hassan-Naeem-code opened this issue Nov 24, 2022 · 2 comments
Open

Slider import from react native resolved #51

Hassan-Naeem-code opened this issue Nov 24, 2022 · 2 comments

Comments

@Hassan-Naeem-code
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts b/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
index e4a4a10..3df2476 100644
--- a/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
+++ b/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
@@ -1,5 +1,5 @@
 import React from "react";
-import { Slider } from "react-native";
+import Slider from '@react-native-community/slider';
 import { HsvColor, IPickerProps, Point2D } from "./typeHelpers";
 declare type SliderProps = {
     onValueChange?: (value: number) => void;
diff --git a/node_modules/react-native-color-picker/dist/HoloColorPicker.js b/node_modules/react-native-color-picker/dist/HoloColorPicker.js
index a177142..95280a3 100644
--- a/node_modules/react-native-color-picker/dist/HoloColorPicker.js
+++ b/node_modules/react-native-color-picker/dist/HoloColorPicker.js
@@ -12,7 +12,8 @@ var __extends = (this && this.__extends) || (function () {
     };
 })();
 import React from "react";
-import { I18nManager, Image, InteractionManager, Slider, StyleSheet, TouchableOpacity, View, } from "react-native";
+import { I18nManager, Image, InteractionManager, StyleSheet, TouchableOpacity, View, } from "react-native";
+import Slider from '@react-native-community/slider';
 import tinycolor from "tinycolor2";
 import { createPanResponder } from "./utils";
 var HoloColorPicker = /** @class */ (function (_super) {
diff --git a/node_modules/react-native-color-picker/src/HoloColorPicker.tsx b/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
index 51a7bcc..6707587 100644
--- a/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
+++ b/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
@@ -4,13 +4,12 @@ import {
   Image,
   InteractionManager,
   PanResponderInstance,
-  Slider,
   StyleSheet,
   TouchableOpacity,
   View,
 } from "react-native"
 import tinycolor from "tinycolor2"
-
+import Slider from '@react-native-community/slider';
 import { HsvColor, IPickerProps, Point2D } from "./typeHelpers"
 import { createPanResponder } from "./utils"
 

This issue body was partially generated by patch-package.

@KthProg
Copy link

KthProg commented Nov 11, 2023

Thanks man.

@seba9999
Copy link

seba9999 commented Mar 18, 2024

Did you guys are using expo ?

Seems that I can't create a developement client build with a patched package ... I still have the error on mounting the component 😢

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants