Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Slider has been extracted from react-native core and will be removed in a future release #22

Open
smartcris opened this issue Jan 25, 2020 · 10 comments

Comments

@smartcris
Copy link

It can now be installed and imported from '@react-native-community/slider' instead of 'react-native'. See https://github.com/react-native-community/react-native-slider

@sodik82
Copy link
Contributor

sodik82 commented Feb 2, 2020

you can use it now via sliderComponent props in 0.5.0

@sodik82 sodik82 closed this as completed Feb 2, 2020
@fritzfr
Copy link

fritzfr commented Feb 5, 2020

@sodik82 I am still getting a warning, even when I do provide this prop.
Screenshot 2020-02-05 at 12 58 08

My Code:

import { ColorPicker, toHsv, fromHsv } from 'react-native-color-picker';
import Slider from '@react-native-community/slider';
// ...

<ColorPicker
	sliderComponent={Slider}
	color={headColor}
	style={{ flex: 1 }} />

@sodik82 sodik82 reopened this Feb 5, 2020
@sodik82
Copy link
Contributor

sodik82 commented Feb 8, 2020

can you try with 0.5.1?

@fritzfr
Copy link

fritzfr commented Feb 12, 2020

@sodik82 Yip, worked. Thanks!

@sodik82 sodik82 closed this as completed Feb 12, 2020
@fritzfr
Copy link

fritzfr commented Feb 13, 2020

@sodik82 Actually I have to reopen, the issue still persists. It was only gone shortly but the warning is back on every reload of my app. Same stack trace as above.

@ridzwanari
Copy link

same goes to me .. but when using trianglecolerpicker the error do not pop out when everytime I reload the app

@sodik82 Actually I have to reopen, the issue still persists. It was only gone shortly but the warning is back on every reload of my app. Same stack trace as above.

@sodik82 sodik82 reopened this Jun 10, 2022
@oleksii-jointoit
Copy link

you can use it now via sliderComponent props in 0.5.0

Thanks, I added

import Slider from '@react-native-community/slider';
<ColorPicker
sliderComponent={Slider}
..
/>

and it works

@Jake-Mulhern
Copy link

I made a post earlier saying that I had figured out how to add the react-native-community slider and then set the color on it by providing this as the sliderComponent

const renderSliderComponent = () => {
    return (
      <View>
        <Slider 
          minimumTrackTintColor={theme.colors.medium}
        />
      </View>
    )
  }

However, I realized that providing it this way changes the color of the slider but then the sliders stop working. Is there any props that I can add that would make it so that the sliders still work?

@sodik82
Copy link
Contributor

sodik82 commented Oct 14, 2022

@Jake-Mulhern - you need to pass prop to the slider so that it can work

(props) => .... <Slider {...props} color="yellow"/>

@Jake-Mulhern
Copy link

Jake-Mulhern commented Oct 14, 2022

you need to pass prop to the slider so that it can work

(props) => .... <Slider {...props} color="yellow"/>

@sodik82 when I pass {...props} in to the component it breaks the sliders. They are just stuck in the same location and won't move even if I don't pass the minimumTrackTintColor in as another prop.

When I log the props being passed in I get this.

{
  "onValueChange": [Function bound ],
  "value": 1,
}
Object {
  "onValueChange": [Function bound ],
  "value": 0.4823529411764706,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants