Skip to content

Commit cf64b24

Browse files
committed
chore: cleanup
1 parent 3d89f3a commit cf64b24

File tree

6 files changed

+11
-7
lines changed

6 files changed

+11
-7
lines changed

packages/aws-fargate/src/activate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function init() {
5858
backendConnector.init({
5959
config,
6060
identityProvider,
61-
stopSendingOnFailure: false,
61+
// TODO: false or true?
6262
propagateErrorsUpstream: true,
6363
defaultTimeout: 950
6464
});

packages/azure-container-services/src/activate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function init() {
3636
backendConnector.init({
3737
config,
3838
identityProvider,
39-
stopSendingOnFailure: false,
39+
// TODO: false or true?
4040
propagateErrorsUpstream: true,
4141
defaultTimeout: 950
4242
});

packages/google-cloud-run/src/activate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ function init() {
5555
backendConnector.init({
5656
config,
5757
identityProvider,
58-
stopSendingOnFailure: false,
59-
propagateErrorsUpstream: true,
58+
// TODO: ?
59+
propagateErrorsUpstream: false,
6060
defaultTimeout: 950
6161
});
6262

packages/opentelemetry-exporter/src/index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,11 @@ class InstanaExporter {
9797
instanaEnvironment.validate();
9898

9999
if (instanaEnvironment.isValid()) {
100+
<<<<<<< HEAD
100101
instanaBackendConnector.init({ config: { logger }, stopSendingOnFailure: false, propagateErrorsUpstream: true });
102+
=======
103+
instanaBackendConnector.init({ logger }, null, true);
104+
>>>>>>> bb612d3e (chore: cleanup)
101105
this._isShutdown = false;
102106
}
103107
}

packages/serverless-collector/src/activate.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ async function init() {
3535
backendConnector.init({
3636
config,
3737
identityProvider,
38-
stopSendingOnFailure: false,
39-
propagateErrorsUpstream: true,
38+
// TODO: ?
39+
propagateErrorsUpstream: false,
4040
defaultTimeout: 950
4141
});
4242

packages/serverless/test/backend_connector_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ describe('[UNIT] backend connector', () => {
8989
it('when lambda extension is used & heartbeat is working, but timeout when talking to extension', async () => {
9090
expect(global.clearInterval.called).to.be.false;
9191

92-
backendConnector.init({ config, stopSendingOnFailure: false, useLambdaExtension: true });
92+
backendConnector.init({ config, useLambdaExtension: true });
9393

9494
expect(uninstrumentedHttp.http.request.called).to.be.true;
9595
expect(uninstrumentedHttp.http.request.callCount).to.eql(1);

0 commit comments

Comments
 (0)