Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric cassandra_storage_hints_in_progress must be gauge, not counter #122

Open
smarsching opened this issue Jan 22, 2025 · 0 comments · May be fixed by #123
Open

Metric cassandra_storage_hints_in_progress must be gauge, not counter #122

smarsching opened this issue Jan 22, 2025 · 0 comments · May be fixed by #123

Comments

@smarsching
Copy link

The cassandra_storage_hints_in_progress is currently exposed as a metric of type counter.

This is incorrect, because according to the specification of Prometheus metric types, a counter must only ever increase and never decrease (except being reset to zero on restart). However, the “hints in progress” metric will decrease whenever hints have been successfully processed.

Therefore, this metrics must be exposed as a gauge instead of a counter.
smarsching added a commit to smarsching/cassandra-exporter that referenced this issue Jan 22, 2025
@smarsching
Change cassandra_storage_hints_in_progress from counter to gauge.
8850159 
This metric cannot be a Prometheus counter because it may (and typically
will) decrease.

Closes instaclustr#122.
@smarsching smarsching linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change cassandra_storage_hints_in_progress from counter to gauge smarsching/cassandra-exporter
1 participant
@smarsching