Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #93

Open
17 of 19 tasks
adamrauh opened this issue Feb 14, 2022 · 0 comments
Open
17 of 19 tasks

Maintenance #93

adamrauh opened this issue Feb 14, 2022 · 0 comments

Comments

@adamrauh
Copy link
Collaborator

adamrauh commented Feb 14, 2022

A few things that need to be cleaned up as I've been thinking about the package/writing things up. Most of these are relatively minor, but non-trivial updates that should be done.

  • Fix PlaceboTest to work with analytical standard errors.
  • optimizations to PlaceboTest for bootstraps
  • Exact matching should handle time-variant variables (Tabling this for now, will be integrated when caliper functionality is fully done)
  • exact matching should handle multiple variables (Tabling this for now, will be integrated when caliper functionality is fully done)
  • Refactor code
  • Ensure that the results of DisplayTreatment are relatively normal/simple ggplot2 objects and can be manipulated with standard syntax. Right now the function seems complicated
  • DisplayTreatment produces an object that is "backward". Fix it.
  • balance_scatter function needs to be updated with the expectations of dimensions of the new get_covariate_balance results.
  • Simplify the arguments of balance_scatter. No need to take an unrefined matched set, when we can just calculate it using get_covariate_balance from a refined set.
  • Fix ART in moderator bug over in Estimating ART w/ a moderator #92
  • Standardize diagnostic function names/UIs. Utility/diagnostic functions should have similar formats/names. Eg. PlaceboTest and get_covariate_balance should follow similar schemes. Everything should take similar arguments and produce similar objects.
  • Incorporate restrict.control.period option from big_data_checks
  • update documentation/code results with resolution of ATE discussion
  • (optional) include an additional covariate in the included Acemoglu data. This might be helpful for documenting some features
  • implement the correct ATC
  • remove continuous matching remnants for stable release
  • Fix summary spacing/print out issues
  • Fix Refactor internal usage of formula objects + parse_and_prep #68
  • Fix Possible bug related to placebo tests #110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant