Replies: 1 comment 4 replies
-
@Moosems, in general, I prefer to use constants (even for flake8-tkinter my original idea was to enforce using constants: https://github.com/rdbende/flake8-tkinter/blob/798501c613c09776bf27950158a4b69d5e90229c/README.md). Even more, I'd prefer if there were enums instead of constants, and type annotations for parameters in the tkinter code, so I would know which values are possible without the need to search for documentation or examples of code. So, no, I'm not changing constants to string literals. |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I would suggest changing the tkinter constants to strings. Example:
tk.SW
-> "sw". It makes the code look a little cleaner and there's no harm to changing them. If you prefer using the constants, go ahead, it works either way :D.Beta Was this translation helpful? Give feedback.
All reactions