From 20c1648518ca5d567f398955ed5808568b2d83c3 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Tue, 21 Jan 2025 21:19:59 -0800 Subject: [PATCH 1/6] # 1089 Use title case for label="Report Preview" --- teal.Rproj | 1 + 1 file changed, 1 insertion(+) diff --git a/teal.Rproj b/teal.Rproj index ab99014abb..747f142420 100644 --- a/teal.Rproj +++ b/teal.Rproj @@ -1,4 +1,5 @@ Version: 1.0 +ProjectId: 3f2f7ba1-ea32-43d1-8b16-74b91ab6ee1d RestoreWorkspace: Default SaveWorkspace: Default From b755b0bca6c91c74786f8e1dc57431ea06a4b1f9 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Tue, 21 Jan 2025 21:24:25 -0800 Subject: [PATCH 2/6] # 1089 use title case for label in default_module --- R/reporter_previewer_module.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/reporter_previewer_module.R b/R/reporter_previewer_module.R index 19b707b34f..56e906e466 100644 --- a/R/reporter_previewer_module.R +++ b/R/reporter_previewer_module.R @@ -19,7 +19,7 @@ #' #' @export #' -reporter_previewer_module <- function(label = "Report previewer", server_args = list()) { +reporter_previewer_module <- function(label = "Report Previewer", server_args = list()) { checkmate::assert_string(label) checkmate::assert_list(server_args, names = "named") checkmate::assert_true(all(names(server_args) %in% names(formals(teal.reporter::reporter_previewer_srv)))) From b7d5e698b6c592d4c31eb45ca8b97ba429e6d212 Mon Sep 17 00:00:00 2001 From: jim Date: Tue, 21 Jan 2025 21:32:09 -0800 Subject: [PATCH 3/6] Delete teal.Rproj --- teal.Rproj | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100644 teal.Rproj diff --git a/teal.Rproj b/teal.Rproj deleted file mode 100644 index 747f142420..0000000000 --- a/teal.Rproj +++ /dev/null @@ -1,24 +0,0 @@ -Version: 1.0 -ProjectId: 3f2f7ba1-ea32-43d1-8b16-74b91ab6ee1d - -RestoreWorkspace: Default -SaveWorkspace: Default -AlwaysSaveHistory: Default - -EnableCodeIndexing: Yes -UseSpacesForTab: Yes -NumSpacesForTab: 2 -Encoding: UTF-8 - -RnwWeave: Sweave -LaTeX: pdfLaTeX - -AutoAppendNewline: Yes -StripTrailingWhitespace: Yes - -BuildType: Package -PackageUseDevtools: Yes -PackageInstallArgs: --no-multiarch --with-keep.source -PackageBuildBinaryArgs: --no-build-vignettes -PackageCheckArgs: --as-cran -PackageRoxygenize: rd,collate,namespace From dcf5630c68bbbe7ddd332e812f26e790f366f974 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Wed, 22 Jan 2025 11:51:36 -0800 Subject: [PATCH 4/6] restore teal.Rproj --- teal.Rproj | 1 - 1 file changed, 1 deletion(-) diff --git a/teal.Rproj b/teal.Rproj index 747f142420..ab99014abb 100644 --- a/teal.Rproj +++ b/teal.Rproj @@ -1,5 +1,4 @@ Version: 1.0 -ProjectId: 3f2f7ba1-ea32-43d1-8b16-74b91ab6ee1d RestoreWorkspace: Default SaveWorkspace: Default From e12aa7f66735dc6d3b43a0ce3a6aae39cd9b74bc Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Wed, 22 Jan 2025 11:57:23 -0800 Subject: [PATCH 5/6] attempting to restore teal.Rproj --- teal.Rproj | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 teal.Rproj diff --git a/teal.Rproj b/teal.Rproj new file mode 100644 index 0000000000..ab99014abb --- /dev/null +++ b/teal.Rproj @@ -0,0 +1,23 @@ +Version: 1.0 + +RestoreWorkspace: Default +SaveWorkspace: Default +AlwaysSaveHistory: Default + +EnableCodeIndexing: Yes +UseSpacesForTab: Yes +NumSpacesForTab: 2 +Encoding: UTF-8 + +RnwWeave: Sweave +LaTeX: pdfLaTeX + +AutoAppendNewline: Yes +StripTrailingWhitespace: Yes + +BuildType: Package +PackageUseDevtools: Yes +PackageInstallArgs: --no-multiarch --with-keep.source +PackageBuildBinaryArgs: --no-build-vignettes +PackageCheckArgs: --as-cran +PackageRoxygenize: rd,collate,namespace From 5f19064dd491ab50fb1381434e4a11a0b70de789 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Thu, 23 Jan 2025 14:00:28 -0800 Subject: [PATCH 6/6] # 1089 fix test-report_previewer_module (use subject case) --- tests/testthat/test-report_previewer_module.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-report_previewer_module.R b/tests/testthat/test-report_previewer_module.R index dc7e014459..3a1b9c8252 100644 --- a/tests/testthat/test-report_previewer_module.R +++ b/tests/testthat/test-report_previewer_module.R @@ -21,7 +21,7 @@ testthat::test_that("report_previewer_module throws no error and stores label if testthat::test_that("report_previewer_module default label is Report previewer ", { r_p_m <- reporter_previewer_module() - testthat::expect_equal(r_p_m$label, "Report previewer") + testthat::expect_equal(r_p_m$label, "Report Previewer") }) testthat::test_that(