Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all "TODO:" in the codebase #1312

Open
pawelru opened this issue Aug 13, 2024 · 1 comment
Open

Resolve all "TODO:" in the codebase #1312

pawelru opened this issue Aug 13, 2024 · 1 comment
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Aug 13, 2024

Follow-up on: #1253

Resolve all "TODO:"

Apparently, all of them has been introduced in the aforementioned PR

@donyunardi
Copy link
Contributor

As discussed, we can remove the todo's comment under the R folder as pointed in the inline comments.

Acceptance Criteria

  • Add unit test which was previously marked as to do.
  • If module has duplicate labels, we need to make sure that the datasets are still being passed correctly.
  • When we reload the data, the filters are remain the same from previous activities.
  • teal doesn't fail when there's no datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants