Merge branch '1260_warning_when_nothing_appended' into 1104_mutate_delayed

Author: Junlue Zhao

R/CodeClass.R

@@ -85,7 +85,7 @@ CodeClass <- R6::R6Class( # nolint
           private$set_code_single(code_i)
         }
         if (identical(prior, self$code)) {
-          warning("Code is not added because it is identical to previously added code.", call. =  FALSE)
+          warning("Code is not appended because it is identical to previously added code.", call. =  FALSE)
         }
         return(invisible(self))
       }
@@ -107,13 +107,9 @@ CodeClass <- R6::R6Class( # nolint
 
       code <- pretty_code_string(code)
 
-      prior <- self$code
       for (code_single in code) {
         private$set_code_single(code_single, dataname, deps)
       }
-      if (identical(prior, self$code)) {
-        warning("Code is not added because it is identical to previously added code.", call. = FALSE)
-      }
 
       return(invisible(self))
     },

tests/testthat/test-CodeClass.R

@@ -158,7 +158,10 @@ test_that("Duplicated code is appended if it doesn't have a dataname", {
 test_that("Duplicated code is not appended if its dataname is duplicated", {
   cc1 <- CodeClass$new(code = "print('test')", dataname = "test")
   cc2 <- CodeClass$new(code = "print('test')", dataname = "test")
-  cc1$append(cc2)
+  expect_warning(
+    cc1$append(cc2),
+    regexp = "Code is not appended because it is identical to previously added code."
+  )
   expect_equal(
     cc1$get_code(),
     "print(\"test\")")