[Question]: Does choices_selected check if selected is in choices for value_choices?

[llrs-roche]

What is your question?

This issue related to one on tmc which aims to provide better error messages: insightsengineering/teal.modules.clinical#1317. A simple example is:

choices_selected(
  value_choices("ADTTE", "PARAMCD", "PARAM"),
  "OS"
)

Where the selected value is not on the choices and it doesn't return an error or even a warning. Should it return one? I think it does and as such it would be a bug on teal.transform.

Code of Conduct

• I agree to follow this project's Code of Conduct.

Contribution Guidelines

• I agree to follow this project's Contribution Guidelines.

Security Policy

• I agree to follow this project's Security Policy.

[shajoezhu]

i think it should throw an error, as a validation step

[llrs-roche]

Closing as the redesign feature on #256 will error on this case. The equivalent (at this moment) when trying to resolve this would be:

resolver(c(datasets("ADTTE"), variables("PARAMCD", "OS")), 
     within(teal.data::teal_data(), {
        ADTTE <- data.frame(PARAMCD = 1, OS = 1)})
      )
)
Error: No variables selection is possible.