From 0d1308f7dd09e364a28ceffe3436f64344db6a87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?= <211358+averissimo@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:13:23 +0200 Subject: [PATCH] Adds min package version (#405) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WIP :: parent issue: https://github.com/insightsengineering/nestdevs-tasks/issues/7 Supersede: * https://github.com/insightsengineering/teal.slice/pull/332 ### 🔴 Checklist for PR Reviewer [![Scheduled 🕰️](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/teal.slice/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action) _(see comment below)_ - [ ] Tag yourself next to this repo on https://github.com/insightsengineering/nestdevs-tasks/issues/7 - [ ] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [ ] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * https://github.com/insightsengineering/verdepcheck/pull/24 * https://github.com/insightsengineering/verdepcheck/pull/26 - [x] verdepcheck-action * https://github.com/insightsengineering/r-verdepcheck-action/pull/16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --- .github/workflows/scheduled.yaml | 2 +- DESCRIPTION | 43 ++++++++++++++++++++++++-------- NEWS.md | 4 +++ 3 files changed, 37 insertions(+), 12 deletions(-) diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml index b752a49b1..f2ddf6862 100644 --- a/.github/workflows/scheduled.yaml +++ b/.github/workflows/scheduled.yaml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - test-strategy: ["min", "release", "max"] + test-strategy: ["min_cohort", "min_isolated", "release", "max"] uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main name: Dependency Test - ${{ matrix.test-strategy }} 🔢 secrets: diff --git a/DESCRIPTION b/DESCRIPTION index 152cc40f0..2a69df786 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -29,37 +29,58 @@ URL: https://insightsengineering.github.io/teal.slice/, BugReports: https://github.com/insightsengineering/teal.slice/issues Depends: R (>= 4.0), - shiny + shiny (>= 1.6.0) Imports: bslib (>= 0.4.0), - checkmate, - dplyr, + checkmate (>= 2.1.0), + dplyr (>= 1.0.5), grDevices, - htmltools, + htmltools (>= 0.5.4), jsonlite, - lifecycle, + lifecycle (>= 0.2.0), logger (>= 0.2.0), methods, - plotly, - R6, - shinycssloaders, + plotly (>= 4.9.2.2), + R6 (>= 2.2.0), + shinycssloaders (>= 1.0.0), shinyjs, shinyWidgets (>= 0.6.2), teal.data (>= 0.3.0), teal.logger (>= 0.1.1), teal.widgets (>= 0.4.0) Suggests: - knitr, + knitr (>= 1.42), MultiAssayExperiment, - rmarkdown, SummarizedExperiment, testthat (>= 3.1.5), utils, - withr + withr (>= 2.1.0) VignetteBuilder: knitr RdMacros: lifecycle +Config/Needs/verdepcheck: + rstudio/shiny, + rstudio/bslib, + mllg/checkmate, + tidyverse/dplyr, + rstudio/htmltools, + jeroen/jsonlite, + r-lib/lifecycle, + daroczig/logger, + plotly/plotly, + r-lib/R6, + daattali/shinycssloaders, + daattali/shinyjs, + dreamRs/shinyWidgets, + insightsengineering/teal.data, + insightsengineering/teal.logger, + insightsengineering/teal.widgets, + yihui/knitr, + MultiAssayExperiment=bioc::MultiAssayExperiment, + SummarizedExperiment=bioc::SummarizedExperiment, + r-lib/testthat, + r-lib/withr Config/Needs/website: insightsengineering/nesttemplate Encoding: UTF-8 Language: en-US diff --git a/NEWS.md b/NEWS.md index c2e9c2ea8..6439fa1c7 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,9 @@ # teal.slice 0.4.0.9013 +### Miscellaneous + +* Specified minimal version of package dependencies. + # teal.slice 0.4.0 ### New features