-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update ggplot2_args
roxygen2 template or integrate with shared_params
#695
Comments
I don't see an immediate need to remove this tag as long as it's not deprecated. It seems useful and removes duplicated code. |
ggplot2_args
roxygen2 template or integrate with shared_params
ggplot2_args
roxygen2 template or integrate with shared_params
Do you think we can move it to shared_params with a dynamic list of |
# Pull Request <!--- Replace `#nnn` with your issue link for reference. --> - Closes #695 - Part of #624 #### Changes description - Update type in `ggplot2_args` - Minor change to phrasing - Move template file under `man` page to avoid extra folder at root level ([available since](https://roxygen2.r-lib.org/news/index.html?q=template#options-7-0-0) `[email protected]`) - Update `.Rbuildignore` accordingly #### Reviewer should consider - `@template` has been superseded (https://roxygen2.r-lib.org/articles/reuse.html?q=template#superseded) - There's no equivalent though _(with parameterized strings)_ - Alternative: we could add `ggplot2_args` to `shared_params` and specific list of names it can take in `@details` on each function that uses this
AFAIK from reading the documentation it's not possible, but if it is, then that would be the best solution
Yes, either in the details or in a separate section. #' inheritParams shared_params
#' ...
#' @details
#' #### `ggplot2_args`
#' List names for `ggplot2_args` should match the following: `c("default", "A", "B", "C")`.
#'
#' For more details see the vignette: `vignette("custom-ggplot2-arguments", package = "teal.widgets")`. |
@kartikeyakirar found an interesting thing on the documentation about the
@template
tagQ: Should we keep using the
@template
tag? (it has been superseded)take a look at
man-roxygen/ggplot2_args_multi.R
and search forggplot_2_args_multi
If we stop using it, we can add this parameter to the
shared_params
definition and add the custom information to@details
Context
{tmg}
is using the@template
roxygen tag to add a "customizable" parameterggplot2_args
.This template allows a special
<%=ggnames%>
string that defines a placeholder for aggnames
variable and, thus, has a custom documentation for each time it's used. (to supply different allowable values)This tag has been superseded by
{roxygen2}
in favour of inline code.Definition of Done
ggplot2_args
roxygen@template
needs updating along with rest of documentationman/roxygen/template
shared_params
& add specific context to individual man pages.The text was updated successfully, but these errors were encountered: