Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release activities - non-exported functions review #641

Closed
m7pr opened this issue Feb 19, 2024 · 1 comment · Fixed by #680
Closed

Pre-release activities - non-exported functions review #641

m7pr opened this issue Feb 19, 2024 · 1 comment · Fixed by #680
Assignees
@chlebowa
Labels
core enhancement New feature or request

Comments

@m7pr
Copy link
Contributor

m7pr commented Feb 19, 2024 •
edited
Loading

Part of #624 related to non-exported functions review. Please make a PR to pre-release@main
@m7pr m7pr added enhancement New feature or request core labels Feb 19, 2024
@m7pr m7pr mentioned this issue Feb 19, 2024
Closed
26 tasks
@kartikeyakirar kartikeyakirar self-assigned this Feb 22, 2024
@chlebowa
Copy link
Contributor

Hey @kartikeyakirar, how is the progress on this? Do you want me to take over?

@chlebowa chlebowa assigned chlebowa and unassigned kartikeyakirar Feb 26, 2024
@chlebowa chlebowa mentioned this issue Feb 26, 2024
Merged
@chlebowa chlebowa linked a pull request Feb 26, 2024 that will close this issue
641 non exported functions #680
Merged
chlebowa added a commit that referenced this issue Feb 28, 2024
@chlebowa @averissimo @m7pr
641 non exported functions (#680)
ee8cd14 
Closes #641 

Dropped examples for non-exported functions. There were only a few.

Cleaned up a bit. There was a lot of duplication in `create_sparklines`
docs, for instance.

Moved `@export` tags to always be the last ones before function
definition.

---------

Signed-off-by: Aleksander Chlebowski <[email protected]>
Co-authored-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlebowa chlebowa

Labels
core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

641 non exported functions insightsengineering/teal.modules.general
4 participants
@kartikeyakirar @donyunardi @chlebowa @m7pr