Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shinyTree from Depends into Imports #352

Closed
Tracked by #15
pawelru opened this issue Feb 21, 2022 · 2 comments · Fixed by #663
Closed
Tracked by #15

Move shinyTree from Depends into Imports #352

pawelru opened this issue Feb 21, 2022 · 2 comments · Fixed by #663
Assignees
@kpagacz
Labels
core devops enhancement New feature or request

Comments

@pawelru
Copy link
Contributor

pawelru commented Feb 21, 2022 •
edited
Loading

connected with #181

Let's explore if it is feasible to move that package into Imports section. Having it inside Depends has significant side effects that I would like to avoid. That could mean that we would have to have install packages from GitHub (Remotes filed in the DESCRIPTION file?). If cannot be done - please write down why in case one will be looking for it.

UPDATE:
Please have a look at shinyTree/shinyTree#112
@pawelru pawelru added enhancement New feature or request devops labels Feb 21, 2022
@pawelru pawelru mentioned this issue Feb 21, 2022
Closed
16 tasks
@kpagacz kpagacz self-assigned this Mar 23, 2022
@gogonzo gogonzo added the core label Mar 25, 2022
@kpagacz kpagacz closed this as completed Mar 28, 2022
@pawelru
Copy link
Contributor Author

pawelru commented Aug 8, 2023

The aforementioned task has been completed and there is a new CRAN release of shinyTree with the fix we are looking for. I am reopening this.

@pawelru pawelru reopened this Aug 8, 2023
@pawelru pawelru mentioned this issue Jan 24, 2024
Closed
@pawelru pawelru linked a pull request Feb 22, 2024 that will close this issue
643 potential removal of dependencies #663
Merged
@pawelru
Copy link
Contributor Author

pawelru commented Feb 22, 2024

closed with #663

@pawelru pawelru closed this as completed Feb 22, 2024
@pawelru pawelru mentioned this issue Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpagacz kpagacz

Labels
core devops enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

643 potential removal of dependencies insightsengineering/teal.modules.general
3 participants
@gogonzo @pawelru @kpagacz