From a2b31d63cac8781808feee29edd4a7636871f4b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?= <211358+averissimo@users.noreply.github.com> Date: Mon, 29 Jan 2024 15:33:32 +0100 Subject: [PATCH] Adds min package version (#797) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WIP :: parent issue: https://github.com/insightsengineering/nestdevs-tasks/issues/7 Supersede: * #780 ### đŸ”´ What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [ ] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * https://github.com/insightsengineering/verdepcheck/pull/24 * https://github.com/insightsengineering/verdepcheck/pull/26 - [x] verdepcheck-action * https://github.com/insightsengineering/r-verdepcheck-action/pull/16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: AndrĂ© VerĂ­ssimo <211358+averissimo@users.noreply.github.com> Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> --- .github/workflows/scheduled.yaml | 2 +- DESCRIPTION | 67 +++++++++++++++++++++++++------- NEWS.md | 7 ++-- 3 files changed, 58 insertions(+), 18 deletions(-) diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml index b752a49b1..f2ddf6862 100644 --- a/.github/workflows/scheduled.yaml +++ b/.github/workflows/scheduled.yaml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - test-strategy: ["min", "release", "max"] + test-strategy: ["min_cohort", "min_isolated", "release", "max"] uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main name: Dependency Test - ${{ matrix.test-strategy }} đŸ”¢ secrets: diff --git a/DESCRIPTION b/DESCRIPTION index efbc889da..c948c665f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -31,29 +31,29 @@ Depends: tern (>= 0.9.3) Imports: assertthat, - broom, - checkmate, - dplyr, - DT, + broom (>= 0.7.10), + checkmate (>= 2.1.0), + dplyr (>= 1.0.5), + DT (>= 0.13), formatters (>= 0.5.5), ggplot2 (>= 3.4.0), ggrepel, grid, - lifecycle, + lifecycle (>= 0.2.0), logger (>= 0.2.0), - magrittr, + magrittr (>= 1.5), methods, - rlang, + rlang (>= 1.0.0), rlistings (>= 0.2.7), - rmarkdown, + rmarkdown (>= 2.19), rtables (>= 0.6.6), scales, - shiny, + shiny (>= 1.6.0), shinyjs, shinyvalidate, - shinyWidgets, + shinyWidgets (>= 0.5.1), stats, - styler, + styler (>= 1.2.0), teal.code(>= 0.4.1.9009), teal.data (>= 0.3.0.9018), teal.logger (>= 0.1.1), @@ -61,17 +61,56 @@ Imports: teal.widgets (>= 0.4.0), tern.gee (>= 0.1.3), tern.mmrm (>= 0.3.0), - tidyr, + tidyr (>= 0.8.3), utils, vistime Suggests: forcats, - knitr, - lubridate, + knitr (>= 1.34), + lubridate (>= 1.7.9), nestcolor (>= 0.1.0), testthat (>= 3.1.5) VignetteBuilder: knitr +Config/Needs/verdepcheck: + insightsengineering/teal, + insightsengineering/teal.transform, + insightsengineering/tern, + cran/assertthat, + tidymodels/broom, + mllg/checkmate, + tidyverse/dplyr, + rstudio/DT, + insightsengineering/formatters, + tidyverse/ggplot2, + slowkow/ggrepel, + r-lib/lifecycle, + daroczig/logger, + tidyverse/magrittr, + r-lib/rlang, + insightsengineering/rlistings, + rstudio/rmarkdown, + insightsengineering/rtables, + r-lib/scales, + rstudio/shiny, + daattali/shinyjs, + rstudio/shinyvalidate, + dreamRs/shinyWidgets, + r-lib/styler, + insightsengineering/teal.code, + insightsengineering/teal.data, + insightsengineering/teal.logger, + insightsengineering/teal.reporter, + insightsengineering/teal.widgets, + insightsengineering/tern.gee, + insightsengineering/tern.mmrm, + tidyverse/tidyr, + shosaco/vistime, + tidyverse/forcats, + yihui/knitr, + tidyverse/lubridate, + insightsengineering/nestcolor, + r-lib/testthat Config/Needs/website: insightsengineering/nesttemplate Config/testthat/edition: 3 Encoding: UTF-8 diff --git a/NEWS.md b/NEWS.md index b00e860e6..1d2698e28 100644 --- a/NEWS.md +++ b/NEWS.md @@ -16,6 +16,7 @@ ### Miscellaneous * Deprecated the `aval` argument in `tm_t_pp_laboratory` and `tm_g_pp_vitals` and replaced it with the `aval_var` argument. * Deprecated the `avalu` argument in `tm_t_pp_laboratory` and replaced it with the `avalu_var` argument. +* Specified minimal version of package dependencies. # teal.modules.clinical 0.8.16.9010 @@ -77,7 +78,7 @@ ### Enhancements * Updated all synthetic data for tests to version `rcd_2022_02_28`. -* Updated all test files in `tests/testthat/` to `synthetic_cdisc_data("2022_02_28")` +* Updated all test files in `tests/testthat/` to `synthetic_cdisc_data("2022_02_28")` * Reverted missing data checkbox in `tm_t_summary` (encoding and filtering should be separate). * Implemented a new widget that allows dragging and dropping to select comparison groups. * Added the `teal.reporter` functionality to all modules. @@ -329,8 +330,8 @@ ### Miscellaneous * Removed redundant `Analysis Data:` label from Encodings Panel. * Removed limit requiring 15 or fewer columns for tabulation modules. New upper threshold is 100 columns. -* Decreased the lower limit for number of observations required by modules. Safety tables require at least one record. - Requirements for efficacy outputs per treatment group: `tm_a_mmrm` requires five records, `tm_t_logistic` and `tm_t_coxreg` require two records, and the remaining modules require at +* Decreased the lower limit for number of observations required by modules. Safety tables require at least one record. + Requirements for efficacy outputs per treatment group: `tm_a_mmrm` requires five records, `tm_t_logistic` and `tm_t_coxreg` require two records, and the remaining modules require at least one record per treatment group. For graphs, the lower threshold is two records. * Removed argument `cnsr_val` from `tm_t_events_patyear` and added new argument `events_var`. * `arm_ref_comp_observer` to include `parentname` argument.