-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace logo.png by logo.svg #239
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Diff against main
Results for commit: 53445b1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 5 suites 11s ⏱️ Results for commit 53445b1. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit cdb7b35 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @llrs-roche
Pull Request
Replace the logo.png by logo.svg to reduce the package size (1.92Mb to 8Kb for the logo).
Apparently the new logo is not picked up by roxygen2 to be shown on rlistings-package.Rd.
In addition, rendering the README to pick the new logo also caused some new messages to be displayed.
Fixes insightsengineering/nestdevs-tasks#93