Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logo.png by logo.svg #239

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Replace logo.png by logo.svg #239

merged 2 commits into from
Dec 18, 2024

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Replace the logo.png by logo.svg to reduce the package size (1.92Mb to 8Kb for the logo).

Apparently the new logo is not picked up by roxygen2 to be shown on rlistings-package.Rd.
In addition, rendering the README to pick the new logo also caused some new messages to be displayed.

Fixes insightsengineering/nestdevs-tasks#93

Copy link
Contributor

github-actions bot commented Dec 18, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              194      14  92.78%   180, 396-399, 403-406, 435-438, 498
TOTAL                      340      40  88.24%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 53445b1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Unit Tests Summary

  1 files    5 suites   11s ⏱️
 41 tests  41 ✅ 0 💤 0 ❌
125 runs  125 ✅ 0 💤 0 ❌

Results for commit 53445b1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
paginate_listing 💚 $6.24$ $-1.02$ $-8$ $+4$ $0$ $0$

Results for commit cdb7b35

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @llrs-roche

@llrs-roche llrs-roche merged commit 4c3bb23 into main Dec 18, 2024
29 checks passed
@llrs-roche llrs-roche deleted the svg_logo@main branch December 18, 2024 13:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce logo size
2 participants