From 414ea5fa490a996ee0bed84b3aac9b4cbf228071 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?= <211358+averissimo@users.noreply.github.com> Date: Tue, 12 Sep 2023 12:12:34 +0200 Subject: [PATCH] Adds min package version (#111) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit WIP :: parent issue: https://github.com/insightsengineering/nestdevs-tasks/issues/7 Supersede: - #96 ### 🔴 Checklist for PR Reviewer ### 🔴 Checklist for PR Reviewer - [x] Tag yourself next to this repo on https://github.com/insightsengineering/nestdevs-tasks/issues/7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * https://github.com/insightsengineering/verdepcheck/pull/24 * https://github.com/insightsengineering/verdepcheck/pull/26 - [x] verdepcheck-action * https://github.com/insightsengineering/r-verdepcheck-action/pull/16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --- .github/workflows/scheduled.yml | 23 +++++++++++++++++++ DESCRIPTION | 40 ++++++++++++++++++++++----------- NEWS.md | 1 + 3 files changed, 51 insertions(+), 13 deletions(-) create mode 100644 .github/workflows/scheduled.yml diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml new file mode 100644 index 00000000..6b66a892 --- /dev/null +++ b/.github/workflows/scheduled.yml @@ -0,0 +1,23 @@ +--- +name: Scheduled 🕰️ + +on: + schedule: + - cron: '45 3 * * 0' + workflow_dispatch: + +jobs: + dependency-test: + strategy: + fail-fast: false + matrix: + test-strategy: ["min_cohort", "min_isolated", "release", "max"] + uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main + name: Dependency Test - ${{ matrix.test-strategy }} 🔢 + secrets: + REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} + GCHAT_WEBHOOK: ${{ secrets.GCHAT_WEBHOOK }} + with: + strategy: ${{ matrix.test-strategy }} + additional-env-vars: | + PKG_SYSREQS_DRY_RUN=true diff --git a/DESCRIPTION b/DESCRIPTION index 8485ccd1..89208630 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -13,23 +13,37 @@ License: Apache License 2.0 | file LICENSE Depends: R (>= 4.0.0) Imports: - checkmate (>= 2.0), - dplyr, + checkmate (>= 2.1.0), + dplyr (>= 1.1.0), forcats (>= 1.0.0), - glue, - magrittr, + glue (>= 1.0.0), + magrittr (>= 1.5), methods, - rlang, - stringr, - tibble, - yaml + rlang (>= 1.0.0), + stringr (>= 1.4.1), + tibble (>= 1.2), + yaml (>= 2.1.15) Suggests: - knitr, - rmarkdown, - testthat (>= 3.0.0), - withr + knitr (>= 1.42), + rmarkdown (>= 2.19), + testthat (>= 3.0.4), + withr (>= 2.1.0) VignetteBuilder: knitr +Config/Needs/verdepcheck: + mllg/checkmate, + tidyverse/dplyr, + tidyverse/forcats, + tidyverse/glue, + tidyverse/magrittr, + r-lib/rlang, + tidyverse/stringr, + tidyverse/tibble, + yaml=vubiostat/r-yaml, + yihui/knitr, + rstudio/rmarkdown, + r-lib/testthat, + r-lib/withr Config/Needs/website: insightsengineering/nesttemplate Config/testthat/edition: 3 Encoding: UTF-8 @@ -37,7 +51,7 @@ Language: en-US LazyData: true Roxygen: list(markdown = TRUE) RoxygenNote: 7.2.3 -Collate: +Collate: 'assertions.R' 'co_relevels.R' 'cut_by_group.R' diff --git a/NEWS.md b/NEWS.md index 3f08a0be..75343a57 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,6 +3,7 @@ * `empty_rule` is removed now. `rule()` will create a normal `rule` object. * By default `rule` are converting empty space `""` to `NA` upon reformatting. * `list2rule` now tolerates duplicated rules with different names. +* Specified minimal version of package dependencies. # dunlin 0.1.4