Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Act warnings in tests #687

Open
Glazy opened this issue Oct 8, 2022 · 1 comment
Open

React Act warnings in tests #687

Glazy opened this issue Oct 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Glazy
Copy link
Contributor

Glazy commented Oct 8, 2022 •
edited
Loading

Bug description

Some of the component tests output React act warnings which make the console output messy and could potentially lead to some odd race conditions in tests if left.

To Reproduce

  1. npm run test
  2. Examine console output

Expected result

All tests passing with no console warnings.

Actual result

Tests passing with console warnings.

Additional information

act related warnings are currently present in the following components/hooks:
@Glazy Glazy added the bug Something isn't working label Oct 8, 2022
@Glazy Glazy mentioned this issue Oct 8, 2022
Closed
3 tasks
@ThisIsMissEm
Copy link
Contributor

Hi @Glazy, thanks for raising this, I've raised it internally with the developer tools team at Inrupt, as I know we've some changes under discussion about this SDK and I'd like to clarify those before replying here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix act warnings in LogoutButton component Glazy/solid-ui-react
2 participants
@ThisIsMissEm @Glazy