Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when client time is wrong #2406

Open
RubenVerborgh opened this issue Oct 24, 2022 · 1 comment
Open

Crash when client time is wrong #2406

RubenVerborgh opened this issue Oct 24, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@RubenVerborgh
Copy link
Contributor

When the client has the wrong time, depending on the difference, CSS and ESS) will send an error response. See for instance CommunitySolidServer/CommunitySolidServer#1012

solid-client-authn-js does not handle such error responses properly.

To reproduce:

  • Create a pod at https://pod.playground.solidlab.be/idp/register/
  • Set your computer time in the past or the future
  • Try to sign on to any app using solid-client-authn-js
  • The server will send {"error":"invalid_dpop_proof","error_description":"invalid DPoP key binding"}
  • The client will crash
@RubenVerborgh RubenVerborgh added the bug Something isn't working label Oct 24, 2022
@NSeydoux
Copy link
Contributor

Thanks for reporting this! I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants