-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC Issuer discovery from WebID Profile #2014
Comments
This is a feature we want to implement soon. I'll update this issue as it progresses. |
I just wanted to check if there has been any progress on this feature. |
Until the client verifies I think you may consider adding a warning that the clients using this library can't rely on If the client doesn't use |
There hasn't been progress on this yet, unfortunately we've had other features that took priority over this. In particular, there is a significant refactoring of the auth library we have been planning for a while now around the adoption of the pattern where the client doesn't assume the OP will return an Access Token. I'll make sure that if we don't get to it before, what you've described here is implemented as part of that refactoring. |
This is really good news @NSeydoux I think meanwhile you might still want to warn developers that if they want to use It is pretty straightforward:
Possibly this could be reused https://github.com/CommunitySolidServer/access-token-verifier/blob/main/src/algorithm/retrieveWebidTrustedOidcIssuers.ts EDIT: I created CommunitySolidServer/access-token-verifier#211 since DPoP also should be verified. |
Search terms you've used
WebID
Impacted environment
In which environment would the proposed feature apply ?
Feature suggestion
The library should be able to discover OIDC Issuer from WebID Profile this would be used in two places:
getWebidFromTokenPayload
currently it only seems to verify JWT but not if OIDC Issuer is allowed for that WebID. The client can not rely on the fact that the user actually controls WebID without checking it. It seems that currently, the client can't consider a user to be authenticated as WebID without doing that additional verification.Client could use the discovery feature directly to get a list of valid OIDC Issuers and let users select which one they want to use to authenticate.
Use Cases
In https://github.com/janeirodigital/sai-impl-service/ we want to authenticate users and verify their control over the WebID to create an instance of Authorization Agent associated with that WebID.
The front end also should support user entering their WebID, and if multiple OIDC issuers are discovered, prompt the user to select which one they would like to use.
The text was updated successfully, but these errors were encountered: