Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ino-icon: Vertical alignment seems not to work correctly #1340

Closed
3 tasks done
janivo opened this issue Mar 25, 2024 · 0 comments · Fixed by #1379
Closed
3 tasks done

ino-icon: Vertical alignment seems not to work correctly #1340

janivo opened this issue Mar 25, 2024 · 0 comments · Fixed by #1379
Assignees
@TobiasHeimGalindo
Labels
bug This issue describes something that isn't working as expected

Comments

@janivo
Copy link
Collaborator

janivo commented Mar 25, 2024 •
edited by TobiasHeimGalindo
Loading

Description

Recent changes to the ino-icon component were implemented to ensure proper vertical alignment. However, these changes have inadvertently introduced alignment issues when the icon is used within other components, such as the ino-chip. To maintain consistent alignment across all components and prevent layout inconsistencies, we need to investigate and resolve these issues.

Acceptance Criteria

  • Alignment issues introduced by recent changes to the ino-icon component are identified and resolved.
  • The changes do not adversely affect the visual appearance or functionality of other components that use ino-icon.
  • Vertical alignment is consistent and visually appealing across all affected components.
@github-actions github-actions bot added the new This issue has been recently added and has no estimation label Mar 25, 2024
@janivo janivo added bug This issue describes something that isn't working as expected and removed new This issue has been recently added and has no estimation labels Mar 25, 2024
@TobiasHeimGalindo TobiasHeimGalindo self-assigned this Apr 11, 2024
@TobiasHeimGalindo TobiasHeimGalindo mentioned this issue Apr 11, 2024
Merged
4 tasks
janivo pushed a commit that referenced this issue Apr 19, 2024
@TobiasHeimGalindo
fix(elements): align ino-icon vertically (#1379)
e7acf68 
Closes #1340

## Proposed Changes

- Added `vertical-alignment: middle;` to the ino-icon.
- Adjusted alignment settings for all parent components that are
affected by this change to ensure consistent vertical alignment

Parent components that needed adjustment:
- [x] ino-button
- [x] ino-chip
- [x] ino-icon-button (this also seemed to fix the misaligned ripple
issue that has been reocurring before)
- [x] ino-select

other components like the ino-avatar didnt need any refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasHeimGalindo TobiasHeimGalindo

Labels
bug This issue describes something that isn't working as expected
Projects
None yet
Milestone
No milestone
2 participants
@janivo @TobiasHeimGalindo