Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elements-angular: Evaluate standalone mode #1078

Closed
janivo opened this issue Oct 18, 2023 · 2 comments · May be fixed by #1242
Closed

elements-angular: Evaluate standalone mode #1078

janivo opened this issue Oct 18, 2023 · 2 comments · May be fixed by #1242
Assignees
@BenPag

Comments

@janivo
Copy link
Collaborator

janivo commented Oct 18, 2023 •
edited
Loading

Description

Angular now offers a standalone components approach as an alternative to the NgModule approach. Evaluate the feasibility and benefits of transitioning our Angular components to this new standalone format.

Key Considerations:

  • Assess the advantages of adopting standalone components in terms of development workflow, maintainability, and potential performance improvements.
  • Evaluate how the standalone components approach enhances the experience for consumers of our Angular components. Consider factors such as ease of integration, reduced dependencies, and improved flexibility.
  • Investigate whether Stencil, our component compiler, provides a seamless way to export components as standalone
  • Will our current InoElementsConfig still work with this new approach?

Acceptance Criteria

  • Provide a comprehensive report summarizing the benefits and drawbacks of adopting standalone components in Angular.
  • Formulate a clear recommendation on whether to transition to standalone components based on the evaluation.
  • If recommended, outline the steps and considerations for implementing standalone components. This should include any necessary updates to our Angular and Stencil configurations.
@janivo janivo added the new This issue has been recently added and has no estimation label Oct 18, 2023
@janivo janivo removed the new This issue has been recently added and has no estimation label Jan 5, 2024
@BenPag BenPag self-assigned this Feb 6, 2024
@BenPag BenPag mentioned this issue Feb 6, 2024
Draft
@BenPag
Copy link
Collaborator

BenPag commented Feb 8, 2024

Evaluation of providing standalone mode for Angular

  • Stencil provides an export mode for standalone components
    • requires additional output target: dist-custom-elements
  • InoElementsConfig is supported but needs an extra provider export
  • Required a copy of all @Directive to set the standalone property
    • To reduce code duplications we can add a mew layer for shared code
  • The behavior of assets loading like icons changed
    • assets not copied to output automatically
    • assets loaded dynamically via assets path
    • might be a problem when integrate it

Beside this. when we provide this new approach following things we have to update:

  • Our integration guide
  • Add a migration guide to standalone mode

Draft PR for implementing standalone mode: #1242

@janivo
Copy link
Collaborator Author

janivo commented Feb 22, 2024 •
edited
Loading

see resulted task in #1273 and #1274

@janivo janivo closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenPag BenPag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elements-angular): support new angular standalone mode inovex/elements
2 participants
@janivo @BenPag