Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create component: ino-nav-menu #1075

Open
janivo opened this issue Oct 16, 2023 · 0 comments · May be fixed by #1148
Open

Create component: ino-nav-menu #1075

janivo opened this issue Oct 16, 2023 · 0 comments · May be fixed by #1148
Assignees
@janivo @MariaLStefan

Comments

@janivo
Copy link
Collaborator

janivo commented Oct 16, 2023 •
edited
Loading

To prepare for our upcoming patterns section, we require a menu component that will showcase all our headlines in a compact menu format. Currently, this type of menu can be found in our React guide on the landing page. Let's create a web component called "ino-nav-menu."

Requirements

  • The component should be able to receive route names through a property (e.g., an array of strings or as many child <a> elements for flexibility purposes).
  • It should also allow for a sub-menu title to be specified.
  • Users should be able to respond to interactions with the route names, such as by Listing to an routeClick event
  • The menu's positioning should be customizable, allowing users to choose between sticky or absolute positioning.
  • An active route name should be visually highlighted.
  • (Optional) The active route name can dynamically update as the user scrolls, mirroring the behavior seen in our current React guide on the landing page.

Current

Image

Expected

Image
Image

(see our Figma for details)
@janivo janivo added new This issue has been recently added and has no estimation landingpage and removed new This issue has been recently added and has no estimation labels Oct 16, 2023
@janivo janivo changed the title Adjust sub menu to match design Create ino-nav-menu component Oct 18, 2023
@janivo janivo changed the title Create ino-nav-menu component Create component: ino-nav-menu Oct 18, 2023
@iandi09 iandi09 linked a pull request Dec 22, 2023 that will close this issue
Draft
@iandi09 iandi09 removed their assignment Dec 22, 2023
@MariaLStefan MariaLStefan self-assigned this Jan 22, 2024
MariaLStefan added a commit that referenced this issue Jan 30, 2024
@MariaLStefan
Merge branch 'master' into elements-#1075-ino-nav-menu
70e2fe2
MariaLStefan added a commit that referenced this issue Jan 30, 2024
@MariaLStefan
Merge branch 'master' into elements-#1075-ino-nav-menu
b4901a2
MariaLStefan added a commit that referenced this issue Feb 8, 2024
@MariaLStefan
Merge branch 'master' into elements-#1075-ino-nav-menu
23ce579
@janivo janivo self-assigned this Feb 20, 2024
@janivo janivo mentioned this issue Mar 13, 2024
Open
janivo added a commit that referenced this issue Mar 26, 2024
@janivo
Merge branch 'master' into elements-#1075-ino-nav-menu
4cb7745 
# Conflicts:
#	packages/elements/src/components.d.ts
#	packages/landingpage/app/[lang]/getting-started/_components/layout.tsx
#	packages/landingpage/app/[lang]/getting-started/_components/menuSection.tsx
#	packages/landingpage/app/[lang]/getting-started/_components/navigationMenu.module.scss
#	packages/landingpage/app/[lang]/getting-started/_components/navigationMenu.tsx
#	packages/landingpage/app/[lang]/getting-started/angular/angular-guide.mdx
#	packages/landingpage/app/[lang]/getting-started/javascript/javascript-guide.mdx
#	packages/landingpage/app/[lang]/getting-started/react/react-guide.mdx
#	packages/landingpage/app/[lang]/getting-started/vue/vue-guide.mdx
#	packages/landingpage/utils/elementsWrapper.ts
janivo added a commit that referenced this issue Apr 22, 2024
@janivo
Merge branch 'refs/heads/master' into elements-#1075-ino-nav-menu
92ef8de 
# Conflicts:
#	packages/elements/src/components/ino-snackbar/readme.md
janivo added a commit that referenced this issue Apr 22, 2024
@janivo
Merge branch 'refs/heads/master' into elements-#1075-ino-nav-menu
4e6b203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janivo janivo

@MariaLStefan MariaLStefan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elements): new component 'ino-nav-menu' inovex/elements
3 participants
@iandi09 @janivo @MariaLStefan