Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inngestgo to remove inngest.* configuration references #22

Open
tonyhb opened this issue Oct 20, 2023 · 0 comments
Open

Refactor inngestgo to remove inngest.* configuration references #22

tonyhb opened this issue Oct 20, 2023 · 0 comments

Comments

@tonyhb
Copy link
Contributor

tonyhb commented Oct 20, 2023

We shouldn't have circular imports between OSS and this repo. When defining functions in an external lib, I should only need to import this library to configure functions.

EG:

inngestgo.FunctionOptions{
  Concurrency: &inngest.ConcurrencLimits{}
}

This is wrong.

We should:

  1. Move function configurations into their own subpackage inngestgo/fns
  2. Recreate function configuration within this package entirely
  3. Consider ergonomic function configuration helpers, eg fns.FunctionConcurrency(1) as a helper for defining function limits overall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant