Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event payload json parsing error should be non-retriable error #16

Open
djfarrelly opened this issue Jul 25, 2023 · 0 comments
Open

Event payload json parsing error should be non-retriable error #16

djfarrelly opened this issue Jul 25, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@djfarrelly
Copy link
Member

Describe the bug
If the Go SDK cannot parse the incoming event JSON correctly, an error is thrown and is retried until the function is considered failed.

To Reproduce

  1. Define an event payload with time.Time as the struct field type
  2. Send an event with an un parseable value for this, e.g. 2024-07-01
  3. There should be an error unmarshalling event for function error

Expected behavior
I would expect event payload parsing errors to not be retried as the event payload doesn't change across retries, each retry would fail.

This should tell the Inngest executor to not retry this event similar to the TS SDK's "Non Retriable error"

Code snippets / Logs / Screenshots

image

System info (please complete the following information):

github.com/inngest/inngestgo v0.4.3-0.20230710181215-c7670fdb9b07

Additional context
n/a

@djfarrelly djfarrelly added the bug Something isn't working label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants