Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CommonJS module system to ESM #314

Open
andraskvr opened this issue Oct 8, 2021 · 0 comments
Open

Migrate from CommonJS module system to ESM #314

andraskvr opened this issue Oct 8, 2021 · 0 comments

Comments

@andraskvr
Copy link
Contributor

The ESM module system is getting wider adoption, the problem is that importing an ESM module from a CommonJS module, such as the vscode-inmanta extension itself is not supported (without some hacks).
It should work the other way around, so the proposal is to turn vscode-inmanta to an ESM module as well.

It's also worth to check if using ESM modules VSCode extensions is supported or not.

Some resources:
https://nodejs.org/api/packages.html#packages_determining_module_system
https://redfin.engineering/node-modules-at-war-why-commonjs-and-es-modules-cant-get-along-9617135eeca1

After this the dependabot updates of getPort version 6 can be resumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant