From 6f30b16b34d42f158b0754163da194dcbecbff62 Mon Sep 17 00:00:00 2001 From: Tyson Gern Date: Mon, 6 May 2024 06:30:07 -0600 Subject: [PATCH] Remove unnecessary clear function from test database --- internal/analyzer/analyze_test.go | 1 - internal/analyzer/embeddings_gateway_test.go | 3 --- internal/app/index_test.go | 1 - internal/collector/chunks_gateway_test.go | 2 -- internal/collector/chunks_service_test.go | 1 - internal/collector/collect_test.go | 1 - internal/collector/data_gateway_test.go | 2 -- pkg/testsupport/test_connection.go | 8 ++------ 8 files changed, 2 insertions(+), 17 deletions(-) diff --git a/internal/analyzer/analyze_test.go b/internal/analyzer/analyze_test.go index bceb328..8248b4c 100644 --- a/internal/analyzer/analyze_test.go +++ b/internal/analyzer/analyze_test.go @@ -24,7 +24,6 @@ func TestAnalyzer_Analyze(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() embeddingsGateway := analyzer.NewEmbeddingsGateway(testDb.DB) chunksGateway := collector.NewChunksGateway(testDb.DB) diff --git a/internal/analyzer/embeddings_gateway_test.go b/internal/analyzer/embeddings_gateway_test.go index 8de9397..3d5c1e5 100644 --- a/internal/analyzer/embeddings_gateway_test.go +++ b/internal/analyzer/embeddings_gateway_test.go @@ -13,7 +13,6 @@ import ( func TestEmbeddingsGateway_UnprocessedIds(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() gateway := analyzer.NewEmbeddingsGateway(testDb.DB) @@ -32,7 +31,6 @@ func TestEmbeddingsGateway_UnprocessedIds(t *testing.T) { func TestEmbeddingsGateway_Save(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() gateway := analyzer.NewEmbeddingsGateway(testDb.DB) @@ -52,7 +50,6 @@ func TestEmbeddingsGateway_Save(t *testing.T) { func TestEmbeddingsGateway_FindSimilar(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() gateway := analyzer.NewEmbeddingsGateway(testDb.DB) diff --git a/internal/app/index_test.go b/internal/app/index_test.go index aaccaeb..9caeb53 100644 --- a/internal/app/index_test.go +++ b/internal/app/index_test.go @@ -46,7 +46,6 @@ func TestIndex_Post(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() testDb.Execute("insert into data (id, source, content) values ('aaaaaaaa-2f3f-4bc9-8dba-ba397156cc16', 'https://example.com', 'some content')") testDb.Execute("insert into chunks (id, data_id, content) values ('bbbbbbbb-2f3f-4bc9-8dba-ba397156cc16', 'aaaaaaaa-2f3f-4bc9-8dba-ba397156cc16','a chunk')") diff --git a/internal/collector/chunks_gateway_test.go b/internal/collector/chunks_gateway_test.go index 6b317d8..f0d708c 100644 --- a/internal/collector/chunks_gateway_test.go +++ b/internal/collector/chunks_gateway_test.go @@ -12,7 +12,6 @@ import ( func TestChunksGateway_Save(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() gateway := collector.NewChunksGateway(testDb.DB) @@ -30,7 +29,6 @@ func TestChunksGateway_Save(t *testing.T) { func TestChunksGateway_Get(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() gateway := collector.NewChunksGateway(testDb.DB) diff --git a/internal/collector/chunks_service_test.go b/internal/collector/chunks_service_test.go index 13462cd..a3d517f 100644 --- a/internal/collector/chunks_service_test.go +++ b/internal/collector/chunks_service_test.go @@ -12,7 +12,6 @@ import ( func TestChunksService_SaveChunks(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() chunksGateway := collector.NewChunksGateway(testDb.DB) chunksService := collector.NewChunksService(DummyChunker{}, chunksGateway) diff --git a/internal/collector/collect_test.go b/internal/collector/collect_test.go index 8b154d4..ddf444a 100644 --- a/internal/collector/collect_test.go +++ b/internal/collector/collect_test.go @@ -34,7 +34,6 @@ func TestCollector_Collect(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() client := http.Client{} extractor := feedsupport.NewExtractor(client) diff --git a/internal/collector/data_gateway_test.go b/internal/collector/data_gateway_test.go index 870a920..c205507 100644 --- a/internal/collector/data_gateway_test.go +++ b/internal/collector/data_gateway_test.go @@ -12,7 +12,6 @@ import ( func TestDataGateway_Save(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() dataGateway := collector.NewDataGateway(testDb.DB) @@ -30,7 +29,6 @@ func TestDataGateway_Save(t *testing.T) { func TestDataGateway_Exists(t *testing.T) { testDb := testsupport.NewTestDb(t) defer testDb.Close() - testDb.ClearTables() dataGateway := collector.NewDataGateway(testDb.DB) diff --git a/pkg/testsupport/test_connection.go b/pkg/testsupport/test_connection.go index d650ecb..a8c40e9 100644 --- a/pkg/testsupport/test_connection.go +++ b/pkg/testsupport/test_connection.go @@ -22,6 +22,8 @@ func NewTestDb(t *testing.T) *TestDb { assert.NoError(t, err, "unable to create test database") }) + println("created test database: " + testDbName) + return &TestDb{ DB: dbsupport.CreateConnection(fmt.Sprintf("postgres://starter:starter@localhost:5432/%s?sslmode=disable", testDbName)), t: t, @@ -39,12 +41,6 @@ func (tdb *TestDb) Close() { }) } -func (tdb *TestDb) ClearTables() { - tdb.Execute("delete from embeddings") - tdb.Execute("delete from chunks") - tdb.Execute("delete from data") -} - func (tdb *TestDb) Execute(statement string, arguments ...any) { _, err := tdb.DB.Exec(statement, arguments...) assert.NoError(tdb.t, err)